Fix GKE not being able to disable Cilium Policies

[maxi-cit]

Fixes: hashicorp/terraform-provider-google#19360

The issue was caused due to the 'omitempty' flag on the 'DesiredEnableCiliumClusterwideNetworkPolicy' attribute on the struct that builds the request on the library end. So I am forcing it to be sent whenever there is a change.

Other fields suffer of the same issue, but I believe this is something that this issues should be treated on a case basis.

Release Note Template for Downstream PRs (will be copied)

container: fixed issue which caused to not being able to disable `enable_cilium_clusterwide_network_policy` field on `google_container_cluster`.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 74 insertions(+), 61 deletions(-))
google-beta provider: Diff ( 2 files changed, 74 insertions(+), 61 deletions(-))

[modular-magician]

Tests analytics

Total tests: 212
Passed tests: 198
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_enableCiliumPolicies

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_enableCiliumPolicies[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[c2thorn]

Hi @maxi-cit

The Magic Modules repository has recently migrated from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request has likely become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.

You also have the option to update the pull request yourself. You can view updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me or your reviewer know if you have any further questions!

[maxi-cit]

Thanks @c2thorn, I will update accordingly

[github-actions]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

removing from queue pending updates for go rewrite

[maxi-cit]

Hello @c2thorn could you run the tests please? I check it locally and removing the .erb files should be enough to solve conflicts.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 74 insertions(+), 61 deletions(-))
google-beta provider: Diff ( 2 files changed, 74 insertions(+), 61 deletions(-))

[modular-magician]

Tests analytics

Total tests: 212
Passed tests: 199
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages

• container

🟢 All tests passed!

View the build log