Support prodcuer port in network endpoint group

[ericlin0101]

Release Note Template for Downstream PRs (will be copied)

compute: added the `psc_data` field to the `google_compute_region_network_endpoint_group` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 35 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 35 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_network_endpoint_group (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_endpoint_group" "primary" {
  psc_data = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1015
Passed tests: 940
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[SarahFrench]

👋 Hi, thanks for your PR!

We just changed our code generator (details here) and currently this PR is doing some things the old way, impacting your changes being generated correctly.

I've left some suggested changes about how to fix them, and once that's sorted I'll do a wider review

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 100 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1015
Passed tests: 940
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[SarahFrench]

Hi @ericlin0101 - Thanks for your PR & bearing with the code generator changes!

I took a look at the API docs for this resource and I can't see the producerPort field present in the public documentation, instead there's only:

  "pscData": {
    "consumerPscAddress": string,
    "pscConnectionId": string,
    "pscConnectionStatus": enum
  }

From your profile I see Google is listed as your employer, so I assume you are a Googler and this is a field that's being added to the API soon, and the public docs are lagging a bit.

Could you please confirm the above? I'm a HashiCorp employee so we have a bit of an asymmetry about what information is available to each us. In these situations I can only sanity check and LGTM PRs so I want to be explicit about that!

[SarahFrench]

Given what I said in my other review comment, and from looking at the logs for the acceptance test here, I assume that currently the API can accept and use the producerPort value but does not return that value in any responses. If that's the case then ignore_read makes sense here, but I don't have much info to go on when reviewing.

If you could confirm the above I'm happy to LGTM the PR.

[ericlin0101]

@SarahFrench, you are correct—the API can accept the new field, but it cannot return the value yet. We are currently working on this, and it may take a few weeks to roll out.

Additionally, the public documentation is slightly behind. It will be updated once everything is fully implemented.

[SarahFrench]

In that case, do you want to go ahead with this PR being merged? Or to wait until the value is also returned?

[ericlin0101]

Thanks for checking, let us wait until it is been confirmed and tested before merge.

[SarahFrench]

LGTM, waiting for confirmation to merge

Waiting for go-ahead to approve and merge

[github-actions]

@ericlin0101, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@ericlin0101, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[ericlin0101]

@SarahFrench, I believe this is ready to merge. Please proceed with the merge at your convenience. Thank you!

[SarahFrench]

/gcbrun

[SarahFrench]

Just realised I hadn't approved the build - I'll let that complete before merging

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 99 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1064
Passed tests: 990
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[SarahFrench]

That test is failing on multiple PRs and isn't specific to this PR. Reported that here: hashicorp/terraform-provider-google#17838 (comment)

Approving & merging!

[ericlin0101]

@SarahFrench, Thank you. We are all set.

[RomanPavelkoMGM]

After switching to 6.13.0 I started to get constant recreation of my NEGs. I tried to recreate them once with 6.13.0 version but it keeps showing the "recreate" action on new plans. There was no code changes on my side and I also didn't add psc_data field since it's optional and I don't need it. I had to stick to 6.12.0 version to get this issue disappear. Is this a bug of the optional psc_data field?

[SarahFrench]

Hi @RomanPavelkoMGM - comments on closed PRs will not go through our triage process. Please open an issue referencing this PR if you're having a problem. Thanks!