Add key_revocation_action_field to google_compute_instance and related resources

[karolgorc]

reopen of #11741
Included all the change requests from the previous PR

• Added the field to
  • google_compute_instance
  • google_compute_instance_from_template
  • google_compute_instance_from_machine_image
  • google_compute_instance_template
  • google_compute_region_instance_template
• Added tests
• Added data source support
• Added doc changes

Release Note Template for Downstream PRs (will be copied)

compute: added `key_revocation_action_type` to `google_compute_instance` and related resources

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 283 insertions(+))
google-beta provider: Diff ( 13 files changed, 283 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  key_revocation_action_type = # value needed
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  key_revocation_action_type = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1031
Passed tests: 954
Skipped tests: 74
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceTemplate_keyRevocationActionType
• TestAccComputeInstance_keyRevocationActionType
• TestAccComputeRegionInstanceTemplate_keyRevocationActionType

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceTemplate_keyRevocationActionType[Debug log]
TestAccComputeInstance_keyRevocationActionType[Debug log]
TestAccComputeRegionInstanceTemplate_keyRevocationActionType[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

mostly LGTM, only seeing minor formatting updates needed!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 284 insertions(+))
google-beta provider: Diff ( 13 files changed, 284 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  key_revocation_action_type = # value needed
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  key_revocation_action_type = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1039
Passed tests: 966
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

LGTM!