Update Instance.yaml delete_url for Looker

[efeelaiho]

Fixes hashicorp/terraform-provider-google#19467

Release Note Template for Downstream PRs (will be copied)

looker: added `deletion_policy` to `google_looker_instance` to allow force-destroying instances with nested resources by setting `deletion_policy = FORCE` 

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 0
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages

• looker

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceBasicExample
• TestAccLookerInstance_lookerInstanceCustomDomainExample
• TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample
• TestAccLookerInstance_lookerInstanceFipsExample
• TestAccLookerInstance_lookerInstanceFullExample
• TestAccLookerInstance_lookerInstancePscExample
• TestAccLookerInstance_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Debug log]
TestAccLookerInstance_lookerInstanceCustomDomainExample[Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Debug log]
TestAccLookerInstance_lookerInstancePscExample[Debug log]
TestAccLookerInstance_update[Debug log]
🔴 Tests failed when rerunning REPLAYING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[shuyama1]

We'll likely need to hide this change behind a flag as changing resource default deletion behavior is a breaking change according https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/breaking-changes/#resource-level-breaking-changes and can't be made in a minor release. A similar example change: #6474

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 24 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 24 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

[modular-magician]

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceBasicExample
• TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

[modular-magician]

🔴 Several tests got terminated during RECORDING mode.
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 23 insertions(+))
google-beta provider: Diff ( 2 files changed, 23 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 23 insertions(+))
google-beta provider: Diff ( 2 files changed, 23 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

[modular-magician]

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceBasicExample
• TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceBasicExample
• TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 27 insertions(+))
google-beta provider: Diff ( 2 files changed, 27 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

[modular-magician]

Tests analytics

Total tests: 2
Passed tests: 0
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• looker

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceBasicExample
• TestAccLookerInstance_lookerInstanceFipsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]

🔴 Several tests got terminated during RECORDING mode.
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceFipsExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 27 insertions(+))
google-beta provider: Diff ( 2 files changed, 27 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  force_delete = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 31 insertions(+))
google-beta provider: Diff ( 3 files changed, 31 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 7
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• looker

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 31 insertions(+))
google-beta provider: Diff ( 3 files changed, 31 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 7
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• looker

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 91 insertions(+))
google-beta provider: Diff ( 3 files changed, 91 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceForceDeleteExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceForceDeleteExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 91 insertions(+))
google-beta provider: Diff ( 3 files changed, 91 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_lookerInstanceForceDeleteExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccLookerInstance_lookerInstanceForceDeleteExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 91 insertions(+))
google-beta provider: Diff ( 3 files changed, 91 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• looker

🟢 All tests passed!

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[efeelaiho]

@shuyama1 Added a deletion policy and all tests are passing now 👍

[shuyama1]

Thank you! I've also updated the changelog a bit.