Skip to content

Add workforce identity federation config to secure source manager ins… #11951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

umairidris
Copy link
Member

@umairidris umairidris commented Oct 9, 2024

Release Note Template for Downstream PRs (will be copied)

securesourcemanager: added `workforce_identity_federation_config` field to `google_secure_source_manager_instance` resource

@umairidris umairidris marked this pull request as draft October 9, 2024 01:56
Copy link

github-actions bot commented Oct 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from ScottSuarez October 9, 2024 01:57
@umairidris
Copy link
Member Author

Note for reviewer: This field is not yet publicly available. This PR will be kept in draft mode until it is ready.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 146 insertions(+))
google-beta provider: Diff ( 3 files changed, 146 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_secure_source_manager_instance (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_instance" "primary" {
  workforce_identity_federation_config {
    enabled = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstanceWorkforceIdentityFederationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerInstance_secureSourceManagerInstanceWorkforceIdentityFederationExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 146 insertions(+))
google-beta provider: Diff ( 3 files changed, 146 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstanceWorkforceIdentityFederationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerInstance_secureSourceManagerInstanceWorkforceIdentityFederationExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@umairidris
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 146 insertions(+))
google-beta provider: Diff ( 3 files changed, 146 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstanceWorkforceIdentityFederationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSecureSourceManagerInstance_secureSourceManagerInstanceWorkforceIdentityFederationExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice this PR is still in draft. Let me know if there is anything I can do to help

@umairidris
Copy link
Member Author

Thanks @ScottSuarez for checking in, this PR is good to go, but we are waiting for the functionality to roll out. Will update this PR once it is ready.

@umairidris umairidris marked this pull request as ready for review November 11, 2024 16:31
@umairidris
Copy link
Member Author

Hi @ScottSuarez thanks for your patience on this, this PR is ready for review.

@github-actions github-actions bot requested a review from ScottSuarez November 11, 2024 16:32
@umairidris
Copy link
Member Author

@ericpang777 Could you PTAL as well?

@ericpang777
Copy link
Contributor

/lgtm

@ScottSuarez ScottSuarez merged commit ffb8349 into GoogleCloudPlatform:main Nov 11, 2024
14 checks passed
@umairidris umairidris deleted the ssm-wf branch November 11, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants