Skip to content

Adds support for cloudrunv2 Service.invokerIamDisabled #11954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

rafaeltello
Copy link
Contributor

@rafaeltello rafaeltello commented Oct 9, 2024

Fixes hashicorp/terraform-provider-google#19786

Adds support for cloudrunv2 Service.invokerIamDisabled. This is a new, by-invitation only feature described in https://cloud.google.com/run/docs/securing/managing-access#invoker_check

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: added `invoker_iam_disabled` field to `google_cloud_run_v2_service`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 32 insertions(+))
google-beta provider: Diff ( 2 files changed, 32 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (48 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  invoker_iam_disabled = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 48
Passed tests: 43
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 32 insertions(+))
google-beta provider: Diff ( 2 files changed, 32 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (48 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  invoker_iam_disabled = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 48
Passed tests: 43
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 60 insertions(+))
google-beta provider: Diff ( 3 files changed, 60 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (48 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  invoker_iam_disabled = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 60 insertions(+))
google-beta provider: Diff ( 3 files changed, 60 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (48 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  invoker_iam_disabled = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 48
Passed tests: 43
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

🟢 All tests passed!

View the build log

This is a new by-invitation feature documented in
Fixes hashicorp/terraform-provider-google#19786

```release-note:enhancement
cloudrunv2: added invokerIamDisabled field to Service
```
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 84 insertions(+))
google-beta provider: Diff ( 4 files changed, 128 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_v2_service (49 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_v2_service" "primary" {
  invoker_iam_disabled = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 43
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 84 insertions(+))
google-beta provider: Diff ( 4 files changed, 128 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 43
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 85 insertions(+))
google-beta provider: Diff ( 4 files changed, 130 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 43
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceInvokeriamExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@rafaeltello rafaeltello marked this pull request as ready for review October 9, 2024 23:56
@github-actions github-actions bot requested a review from ScottSuarez October 9, 2024 23:57
Copy link

github-actions bot commented Oct 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra, unreferenced function

@github-actions github-actions bot requested a review from ScottSuarez October 11, 2024 20:15
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 57 insertions(+))
google-beta provider: Diff ( 3 files changed, 102 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 44
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

🟢 All tests passed!

View the build log

@ScottSuarez ScottSuarez merged commit 9dc28c8 into GoogleCloudPlatform:main Oct 11, 2024
13 checks passed
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for run_v2 Service.invokerIamDisabled
4 participants