Skip to content

Feature/resource oracle database autonomous database #11960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tulika-aakriti
Copy link
Contributor

Part of: hashicorp/terraform-provider-google#19701

Release Note Template for Downstream PRs (will be copied)

`google_oracle_database_autonomous_database`

@github-actions github-actions bot requested a review from rileykarson October 9, 2024 19:30
Copy link

github-actions bot commented Oct 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4658 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 4658 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1355 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 252 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_autonomous_database (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_autonomous_database" "primary" {
  properties {
    backup_retention_period_days    = # value needed
    character_set                   = # value needed
    cpu_core_count                  = # value needed
    data_storage_size_gb            = # value needed
    db_edition                      = # value needed
    is_storage_auto_scaling_enabled = # value needed
    maintenance_schedule_type       = # value needed
    mtls_connection_required        = # value needed
    n_character_set                 = # value needed
    operations_insights_state       = # value needed
    private_endpoint_ip             = # value needed
    private_endpoint_label          = # value needed
    scheduled_operation_details {
      day_of_week = # value needed
      start_time {
        hours   = # value needed
        minutes = # value needed
        nanos   = # value needed
        seconds = # value needed
      }
      stop_time {
        hours   = # value needed
        minutes = # value needed
        nanos   = # value needed
        seconds = # value needed
      }
    }
    secret_id = # value needed
    state     = # value needed
    vault_id  = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseBasicExample
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseBasicExample[Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@tulika-aakriti tulika-aakriti marked this pull request as draft October 9, 2024 19:55
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4662 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 4662 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1355 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 254 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_autonomous_database (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_autonomous_database" "primary" {
  properties {
    backup_retention_period_days    = # value needed
    character_set                   = # value needed
    cpu_core_count                  = # value needed
    data_storage_size_gb            = # value needed
    db_edition                      = # value needed
    is_storage_auto_scaling_enabled = # value needed
    maintenance_schedule_type       = # value needed
    mtls_connection_required        = # value needed
    n_character_set                 = # value needed
    operations_insights_state       = # value needed
    private_endpoint_ip             = # value needed
    private_endpoint_label          = # value needed
    scheduled_operation_details {
      day_of_week = # value needed
      start_time {
        hours   = # value needed
        minutes = # value needed
        nanos   = # value needed
        seconds = # value needed
      }
      stop_time {
        hours   = # value needed
        minutes = # value needed
        nanos   = # value needed
        seconds = # value needed
      }
    }
    secret_id = # value needed
    state     = # value needed
    vault_id  = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseBasicExample
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseBasicExample[Error message] [Debug log]
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4672 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 4672 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1355 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 261 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_autonomous_database (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_autonomous_database" "primary" {
  properties {
    cpu_core_count         = # value needed
    data_storage_size_gb   = # value needed
    db_edition             = # value needed
    private_endpoint_ip    = # value needed
    private_endpoint_label = # value needed
    secret_id              = # value needed
    vault_id               = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseBasicExample
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseBasicExample[Debug log]
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@tulika-aakriti
Copy link
Contributor Author

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4672 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 4672 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 1355 insertions(+)) Open in Cloud Shell: Diff ( 8 files changed, 261 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_autonomous_database (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_autonomous_database" "primary" {
  properties {
    cpu_core_count         = # value needed
    data_storage_size_gb   = # value needed
    db_edition             = # value needed
    private_endpoint_ip    = # value needed
    private_endpoint_label = # value needed
    secret_id              = # value needed
    vault_id               = # value needed
  }
}

We can not add all these fields as these are optional (should be given if other field are not given) otherwise it will fail in prepare call.
example - InvalidParameter: dataStorageSizeInGBs parameter cannot be used with the dataStorageSizeInTBs parameter"
https://docs.oracle.com/en-us/iaas/api/#/en/database/20160918/datatypes/CreateAutonomousDatabaseBase:~:text=This%20cannot%20be%20used%20in%20conjunction%20with%20adminPassword.

@tulika-aakriti tulika-aakriti marked this pull request as ready for review October 10, 2024 10:31
@github-actions github-actions bot requested a review from rileykarson October 10, 2024 10:32
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4677 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 4677 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1355 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 261 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_autonomous_database (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_autonomous_database" "primary" {
  properties {
    cpu_core_count         = # value needed
    data_storage_size_gb   = # value needed
    db_edition             = # value needed
    private_endpoint_ip    = # value needed
    private_endpoint_label = # value needed
    secret_id              = # value needed
    vault_id               = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4683 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 4683 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1355 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 264 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_autonomous_database (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_autonomous_database" "primary" {
  properties {
    cpu_core_count = # value needed
    secret_id      = # value needed
    vault_id       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from rileykarson October 14, 2024 07:02
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4682 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 4682 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1355 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 262 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_autonomous_database (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_autonomous_database" "primary" {
  properties {
    cpu_core_count = # value needed
    secret_id      = # value needed
    vault_id       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • oracledatabase

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseBasicExample
  • TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseBasicExample[Debug log]
TestAccOracleDatabaseAutonomousDatabase_oracledatabaseAutonomousDatabaseFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

CpuCoreCount, SecretId and VaultId are not supported yet
by partner API.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4587 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 4587 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1322 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 262 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 5
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@tulika-aakriti
Copy link
Contributor Author

Hi Riley, Please review the PR.
Thanks

@github-actions github-actions bot requested a review from rileykarson October 15, 2024 18:08
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4587 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 4587 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1322 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 262 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 9
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • oracledatabase

🟢 All tests passed!

View the build log

@rileykarson rileykarson merged commit 277ddc9 into GoogleCloudPlatform:main Oct 15, 2024
13 checks passed
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
@tulika-aakriti tulika-aakriti deleted the feature/resource_oracle_database_autonomous_database branch November 11, 2024 16:40
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants