-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Feature/resource oracle database autonomous database #11960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/resource oracle database autonomous database #11960
Conversation
…database_autonomous_database
…database_autonomous_database
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_autonomous_database" "primary" {
properties {
backup_retention_period_days = # value needed
character_set = # value needed
cpu_core_count = # value needed
data_storage_size_gb = # value needed
db_edition = # value needed
is_storage_auto_scaling_enabled = # value needed
maintenance_schedule_type = # value needed
mtls_connection_required = # value needed
n_character_set = # value needed
operations_insights_state = # value needed
private_endpoint_ip = # value needed
private_endpoint_label = # value needed
scheduled_operation_details {
day_of_week = # value needed
start_time {
hours = # value needed
minutes = # value needed
nanos = # value needed
seconds = # value needed
}
stop_time {
hours = # value needed
minutes = # value needed
nanos = # value needed
seconds = # value needed
}
}
secret_id = # value needed
state = # value needed
vault_id = # value needed
}
}
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
mmv1/templates/terraform/examples/oracledatabase_autonomous_database_basic.tf.tmpl
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_autonomous_database" "primary" {
properties {
backup_retention_period_days = # value needed
character_set = # value needed
cpu_core_count = # value needed
data_storage_size_gb = # value needed
db_edition = # value needed
is_storage_auto_scaling_enabled = # value needed
maintenance_schedule_type = # value needed
mtls_connection_required = # value needed
n_character_set = # value needed
operations_insights_state = # value needed
private_endpoint_ip = # value needed
private_endpoint_label = # value needed
scheduled_operation_details {
day_of_week = # value needed
start_time {
hours = # value needed
minutes = # value needed
nanos = # value needed
seconds = # value needed
}
stop_time {
hours = # value needed
minutes = # value needed
nanos = # value needed
seconds = # value needed
}
}
secret_id = # value needed
state = # value needed
vault_id = # value needed
}
}
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_autonomous_database" "primary" {
properties {
cpu_core_count = # value needed
data_storage_size_gb = # value needed
db_edition = # value needed
private_endpoint_ip = # value needed
private_endpoint_label = # value needed
secret_id = # value needed
vault_id = # value needed
}
}
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
We can not add all these fields as these are optional (should be given if other field are not given) otherwise it will fail in prepare call. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_autonomous_database" "primary" {
properties {
cpu_core_count = # value needed
data_storage_size_gb = # value needed
db_edition = # value needed
private_endpoint_ip = # value needed
private_endpoint_label = # value needed
secret_id = # value needed
vault_id = # value needed
}
}
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_autonomous_database" "primary" {
properties {
cpu_core_count = # value needed
secret_id = # value needed
vault_id = # value needed
}
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
mmv1/templates/terraform/examples/oracledatabase_autonomous_database_basic.tf.tmpl
Show resolved
Hide resolved
mmv1/templates/terraform/examples/oracledatabase_autonomous_database_basic.tf.tmpl
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_autonomous_database" "primary" {
properties {
cpu_core_count = # value needed
secret_id = # value needed
vault_id = # value needed
}
}
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
CpuCoreCount, SecretId and VaultId are not supported yet by partner API.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 5 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi Riley, Please review the PR. |
mmv1/templates/terraform/examples/oracledatabase_autonomous_database_basic.tf.tmpl
Show resolved
Hide resolved
Co-authored-by: Riley Karson <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 9 Click here to see the affected service packages
🟢 All tests passed! View the build log |
…form#11960) Co-authored-by: Riley Karson <[email protected]>
…form#11960) Co-authored-by: Riley Karson <[email protected]>
…form#11960) Co-authored-by: Riley Karson <[email protected]>
…form#11960) Co-authored-by: Riley Karson <[email protected]>
…form#11960) Co-authored-by: Riley Karson <[email protected]>
…form#11960) Co-authored-by: Riley Karson <[email protected]>
…form#11960) Co-authored-by: Riley Karson <[email protected]>
Part of: hashicorp/terraform-provider-google#19701
Release Note Template for Downstream PRs (will be copied)