Add autoscaling settings to pc management cluster #12002

varshatumburu · 2024-10-15T08:21:14Z

Add terraform support for autoscaling in pc management cluster

Private Cloud Acceptance Tests pass at gpaste/5685698748481536

Release Note Template for Downstream PRs (will be copied)

vmwareengine: added `autoscaling_settings` to `google_vmwareengine_private_cloud` resource

modular-magician · 2024-10-15T08:34:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1017 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 1017 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 285 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vmwareengine_private_cloud (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_private_cloud" "primary" {
  management_cluster {
    autoscaling_settings {
      autoscaling_policies {
        consumed_memory_thresholds {
          scale_in  = # value needed
          scale_out = # value needed
        }
        granted_memory_thresholds {
          scale_in  = # value needed
          scale_out = # value needed
        }
      }
    }
  }
}

modular-magician · 2024-10-15T09:00:54Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-10-15T10:16:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1017 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 1017 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 285 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vmwareengine_private_cloud (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_private_cloud" "primary" {
  management_cluster {
    autoscaling_settings {
      autoscaling_policies {
        consumed_memory_thresholds {
          scale_in  = # value needed
          scale_out = # value needed
        }
        granted_memory_thresholds {
          scale_in  = # value needed
          scale_out = # value needed
        }
      }
    }
  }
}

modular-magician · 2024-10-15T10:42:16Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-10-15T15:50:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1029 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 1029 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 285 insertions(+))

modular-magician · 2024-10-15T16:16:08Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-10-16T03:52:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1029 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 1029 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 285 insertions(+))

modular-magician · 2024-10-16T03:55:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1029 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 1029 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 285 insertions(+))

modular-magician · 2024-10-16T04:18:08Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-10-16T04:21:11Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions · 2024-10-16T09:07:27Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-10-16T10:23:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 811 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 811 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

modular-magician · 2024-10-16T10:49:25Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

mmv1/products/vmwareengine/PrivateCloud.yaml

mmv1/third_party/terraform/services/vmwareengine/resource_vmwareengine_private_cloud_test.go

mmv1/templates/terraform/examples/vmware_engine_private_cloud_full.tf.tmpl

modular-magician · 2024-10-18T06:58:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 811 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 811 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

modular-magician · 2024-10-18T07:24:05Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2024-10-18T07:59:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 809 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 809 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

modular-magician · 2024-10-18T08:24:48Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

zli82016 · 2024-10-21T16:49:48Z

Hello, @varshatumburu , I tried to create a resource with autoscaling_setttings in the configuration locally, but the test failed. It seems like the response doesn't have autoscaling_setttings.

GET /v1/projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc/clusters?alt=json&filter=management%3Dtrue HTTP/1.1

-----------------------------------------------------
2024/10/19 00:18:47 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------

{
  "clusters": [
    {
      "name": "projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc/clusters/tf-test-sample-mgmt-cluster-custom-core-counter48vrygfc",
      "createTime": "2024-10-19T00:12:58.449044150Z",
      "updateTime": "2024-10-19T00:12:59.228101035Z",
      "state": "ACTIVE",
      "management": true,
      "uid": "8504808a-cfc4-4b60-a0dc-de5fb27ee03d",
      "nodeTypeConfigs": {
        "standard-72": {
          "nodeCount": 3,
          "customCoreCount": 32
        }
      }
    }
  ]
}

Do you have an idea for the reason? Thanks.

varshatumburu · 2024-10-21T17:12:30Z

Hello, @varshatumburu , I tried to create a resource with autoscaling_setttings in the configuration locally, but the test failed. It seems like the response doesn't have autoscaling_setttings.

GET /v1/projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc/clusters?alt=json&filter=management%3Dtrue HTTP/1.1

-----------------------------------------------------
2024/10/19 00:18:47 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------

{
  "clusters": [
    {
      "name": "projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc/clusters/tf-test-sample-mgmt-cluster-custom-core-counter48vrygfc",
      "createTime": "2024-10-19T00:12:58.449044150Z",
      "updateTime": "2024-10-19T00:12:59.228101035Z",
      "state": "ACTIVE",
      "management": true,
      "uid": "8504808a-cfc4-4b60-a0dc-de5fb27ee03d",
      "nodeTypeConfigs": {
        "standard-72": {
          "nodeCount": 3,
          "customCoreCount": 32
        }
      }
    }
  ]
}

Do you have an idea for the reason? Thanks.

Hi @zli82016, I would require more information and logs before and after to check. Could you also share the request that was made to update the cluster settings, and if there were any failure messages before/after?

zli82016 · 2024-10-21T17:18:37Z

Hello, @varshatumburu , I didn't update the resource. Instead, I created the resource.

This is the request:

POST /v1/projects/ci-test-project-188019/locations/me-west1-b/privateClouds?alt=json&privateCloudId=tf-test-sample-pcer48vrygfc HTTP/1.1
Host: vmwareengine.googleapis.com
User-Agent: Terraform/1.8.3 (+https://www.terraform.io) Terraform-Plugin-SDK/2.33.0 terraform-provider-google-

{
 "description": "sample updated description",
 "managementCluster": {
  "autoscalingSettings": {
   "autoscalingPolicies": {
    "autoscaling-policy": {
     "consumedMemoryThresholds": {
      "scaleIn": 20,
      "scaleOut": 75
     },
     "cpuThresholds": {
      "scaleIn": 15,
      "scaleOut": 80
     },
     "nodeTypeId": "standard-72",
     "scaleOutSize": 1,
     "storageThresholds": {
      "scaleIn": 20,
      "scaleOut": 80
     }
    }
   },
   "maxClusterNodeCount": 8,
   "minClusterNodeCount": 3
  },
  "clusterId": "tf-test-sample-mgmt-cluster-custom-core-counter48vrygfc",
  "nodeTypeConfigs": {
   "standard-72": {
    "customCoreCount": 32,
    "nodeCount": 3
   }
  }
 },
 "networkConfig": {
  "managementCidr": "192.168.0.0/24",
  "vmwareEngineNetwork": "projects/ci-test-project-188019/locations/global/vmwareEngineNetworks/tf-test-pc-nw-er48vrygfc"
 }
}

The error I got for my test is that

error=
  | After applying this test step, the plan was not empty.
  | stdout:
  | 
  | 
  | Terraform used the selected providers to generate the following execution
  | plan. Resource actions are indicated with the following symbols:
  |   ~ update in-place
  |  <= read (data resources)
  | 
  | Terraform will perform the following actions:
  | 
  |   # data.google_vmwareengine_nsx_credentials.nsx-ds will be read during apply
  |   # (depends on a resource or a module with changes pending)
  |  <= data "google_vmwareengine_nsx_credentials" "nsx-ds" {
  |       + id       = (known after apply)
  |       + parent   = "projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc"
  |       + password = (known after apply)
  |       + username = (known after apply)
  |     }
  | 
  |   # data.google_vmwareengine_private_cloud.ds will be read during apply
  |   # (depends on a resource or a module with changes pending)
  |  <= data "google_vmwareengine_private_cloud" "ds" {
  |       + deletion_delay_hours              = (known after apply)
  |       + description                       = (known after apply)
  |       + hcx                               = (known after apply)
  |       + id                                = (known after apply)
  |       + location                          = "me-west1-b"
  |       + management_cluster                = (known after apply)
  |       + name                              = "tf-test-sample-pcer48vrygfc"
  |       + network_config                    = (known after apply)
  |       + nsx                               = (known after apply)
  |       + send_deletion_delay_hours_if_zero = (known after apply)
  |       + state                             = (known after apply)
  |       + type                              = (known after apply)
  |       + uid                               = (known after apply)
  |       + vcenter                           = (known after apply)
  |     }
  | 
  |   # data.google_vmwareengine_vcenter_credentials.vcenter-ds will be read during apply
  |   # (depends on a resource or a module with changes pending)
  |  <= data "google_vmwareengine_vcenter_credentials" "vcenter-ds" {
  |       + id       = (known after apply)
  |       + parent   = "projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc"
  |       + password = (known after apply)
  |       + username = (known after apply)
  |     }
  | 
  |   # google_vmwareengine_private_cloud.vmw-engine-pc will be updated in-place
  |   ~ resource "google_vmwareengine_private_cloud" "vmw-engine-pc" {
  |         id                                = "projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc"
  |         name                              = "tf-test-sample-pcer48vrygfc"
  |         # (10 unchanged attributes hidden)
  | 
  |       ~ management_cluster {
  |             # (1 unchanged attribute hidden)
  | 
  |           + autoscaling_settings {
  |               + max_cluster_node_count = 8
  |               + min_cluster_node_count = 3
  | 
  |               + autoscaling_policies {
  |                   + autoscale_policy_id = "autoscaling-policy"
  |                   + node_type_id        = "standard-72"
  |                   + scale_out_size      = 1
  | 
  |                   + consumed_memory_thresholds {
  |                       + scale_in  = 20
  |                       + scale_out = 75
  |                     }
  | 
  |                   + cpu_thresholds {
  |                       + scale_in  = 15
  |                       + scale_out = 80
  |                     }
  | 
  |                   + storage_thresholds {
  |                       + scale_in  = 20
  |                       + scale_out = 80
  |                     }
  |                 }
  |             }
  | 
  |             # (1 unchanged block hidden)
  |         }
  | 
  |         # (1 unchanged block hidden)
  |     }
  | 
  | Plan: 0 to add, 1 to change, 0 to destroy.

I didn't see other errors.

varshatumburu · 2024-10-21T17:24:48Z

Hello, @varshatumburu , I didn't update the resource. Instead, I created the resource.

This is the request:

POST /v1/projects/ci-test-project-188019/locations/me-west1-b/privateClouds?alt=json&privateCloudId=tf-test-sample-pcer48vrygfc HTTP/1.1
Host: vmwareengine.googleapis.com
User-Agent: Terraform/1.8.3 (+https://www.terraform.io) Terraform-Plugin-SDK/2.33.0 terraform-provider-google-

{
 "description": "sample updated description",
 "managementCluster": {
  "autoscalingSettings": {
   "autoscalingPolicies": {
    "autoscaling-policy": {
     "consumedMemoryThresholds": {
      "scaleIn": 20,
      "scaleOut": 75
     },
     "cpuThresholds": {
      "scaleIn": 15,
      "scaleOut": 80
     },
     "nodeTypeId": "standard-72",
     "scaleOutSize": 1,
     "storageThresholds": {
      "scaleIn": 20,
      "scaleOut": 80
     }
    }
   },
   "maxClusterNodeCount": 8,
   "minClusterNodeCount": 3
  },
  "clusterId": "tf-test-sample-mgmt-cluster-custom-core-counter48vrygfc",
  "nodeTypeConfigs": {
   "standard-72": {
    "customCoreCount": 32,
    "nodeCount": 3
   }
  }
 },
 "networkConfig": {
  "managementCidr": "192.168.0.0/24",
  "vmwareEngineNetwork": "projects/ci-test-project-188019/locations/global/vmwareEngineNetworks/tf-test-pc-nw-er48vrygfc"
 }
}

The error I got for the test is that

error=
  | After applying this test step, the plan was not empty.
  | stdout:
  | 
  | 
  | Terraform used the selected providers to generate the following execution
  | plan. Resource actions are indicated with the following symbols:
  |   ~ update in-place
  |  <= read (data resources)
  | 
  | Terraform will perform the following actions:
  | 
  |   # data.google_vmwareengine_nsx_credentials.nsx-ds will be read during apply
  |   # (depends on a resource or a module with changes pending)
  |  <= data "google_vmwareengine_nsx_credentials" "nsx-ds" {
  |       + id       = (known after apply)
  |       + parent   = "projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc"
  |       + password = (known after apply)
  |       + username = (known after apply)
  |     }
  | 
  |   # data.google_vmwareengine_private_cloud.ds will be read during apply
  |   # (depends on a resource or a module with changes pending)
  |  <= data "google_vmwareengine_private_cloud" "ds" {
  |       + deletion_delay_hours              = (known after apply)
  |       + description                       = (known after apply)
  |       + hcx                               = (known after apply)
  |       + id                                = (known after apply)
  |       + location                          = "me-west1-b"
  |       + management_cluster                = (known after apply)
  |       + name                              = "tf-test-sample-pcer48vrygfc"
  |       + network_config                    = (known after apply)
  |       + nsx                               = (known after apply)
  |       + send_deletion_delay_hours_if_zero = (known after apply)
  |       + state                             = (known after apply)
  |       + type                              = (known after apply)
  |       + uid                               = (known after apply)
  |       + vcenter                           = (known after apply)
  |     }
  | 
  |   # data.google_vmwareengine_vcenter_credentials.vcenter-ds will be read during apply
  |   # (depends on a resource or a module with changes pending)
  |  <= data "google_vmwareengine_vcenter_credentials" "vcenter-ds" {
  |       + id       = (known after apply)
  |       + parent   = "projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc"
  |       + password = (known after apply)
  |       + username = (known after apply)
  |     }
  | 
  |   # google_vmwareengine_private_cloud.vmw-engine-pc will be updated in-place
  |   ~ resource "google_vmwareengine_private_cloud" "vmw-engine-pc" {
  |         id                                = "projects/ci-test-project-188019/locations/me-west1-b/privateClouds/tf-test-sample-pcer48vrygfc"
  |         name                              = "tf-test-sample-pcer48vrygfc"
  |         # (10 unchanged attributes hidden)
  | 
  |       ~ management_cluster {
  |             # (1 unchanged attribute hidden)
  | 
  |           + autoscaling_settings {
  |               + max_cluster_node_count = 8
  |               + min_cluster_node_count = 3
  | 
  |               + autoscaling_policies {
  |                   + autoscale_policy_id = "autoscaling-policy"
  |                   + node_type_id        = "standard-72"
  |                   + scale_out_size      = 1
  | 
  |                   + consumed_memory_thresholds {
  |                       + scale_in  = 20
  |                       + scale_out = 75
  |                     }
  | 
  |                   + cpu_thresholds {
  |                       + scale_in  = 15
  |                       + scale_out = 80
  |                     }
  | 
  |                   + storage_thresholds {
  |                       + scale_in  = 20
  |                       + scale_out = 80
  |                     }
  |                 }
  |             }
  | 
  |             # (1 unchanged block hidden)
  |         }
  | 
  |         # (1 unchanged block hidden)
  |     }
  | 
  | Plan: 0 to add, 1 to change, 0 to destroy.

I didn't see other errors.

Autoscaling settings will not get added to the cluster without cool down period. Although some are optional fields in the proto, all fields (policy, min, max node count, cool down period) are mandatory for successful addition of autoscaling settings. Please retry by adding cool down period and let me know if you are facing the same issue.

zli82016 · 2024-10-21T17:48:06Z

That makes sense. Do you have any suggestion how long the cool down period should be? Thanks.

modular-magician · 2024-10-25T11:49:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 870 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 870 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

varshatumburu · 2024-10-25T12:01:18Z

Hi @zli82016 , I've added post_create file as requested and tested creation with autoscale settings at gpaste/5982018759557120

modular-magician · 2024-10-25T12:15:29Z

Tests analytics

Total tests: 14
Passed tests: 11
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-25T12:45:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 887 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 887 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

modular-magician · 2024-10-25T12:50:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 883 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 883 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

modular-magician · 2024-10-25T13:12:04Z

Tests analytics

Total tests: 14
Passed tests: 11
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-25T13:16:34Z

Tests analytics

Total tests: 14
Passed tests: 11
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-25T15:47:01Z

🟢 Tests passed during RECORDING mode:
TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-10-25T16:45:29Z

🟢 Tests passed during RECORDING mode:
TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-10-26T11:25:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 883 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 883 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

modular-magician · 2024-10-26T11:55:40Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

zli82016

LGTM. Thanks.

…m#12002)

modular-magician added the service/vmwareengine label Oct 15, 2024

varshatumburu changed the title ~~Add autoscale settings to pc management cluster~~ Add autoscaling settings to pc management cluster Oct 15, 2024

varshatumburu marked this pull request as ready for review October 16, 2024 09:06

github-actions bot requested a review from zli82016 October 16, 2024 09:07

varshatumburu marked this pull request as draft October 16, 2024 11:09

varshatumburu marked this pull request as ready for review October 16, 2024 17:39

zli82016 requested changes Oct 17, 2024

View reviewed changes

github-actions bot requested a review from zli82016 October 18, 2024 06:47

varshatumburu added 5 commits October 25, 2024 06:44

Add required field in thresholds

2db5399

resolve comments

9da098e

edit description

5f97131

edit description

4d4b21f

add post_create autoscale support

1209187

varshatumburu force-pushed the add-autoscale-pc branch from 5f1de47 to 1209187 Compare October 25, 2024 11:37

github-actions bot requested a review from zli82016 October 25, 2024 11:38

varshatumburu added 2 commits October 25, 2024 12:34

edit description

6013a51

edit description

3a0ef57

edit autoscale settings description

e25f24b

zli82016 approved these changes Oct 28, 2024

View reviewed changes

zli82016 merged commit 7803936 into GoogleCloudPlatform:main Oct 28, 2024
15 checks passed

niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Nov 1, 2024

Add autoscaling settings to pc management cluster (GoogleCloudPlatfor…

d91d5cd

…m#12002)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024

Add autoscaling settings to pc management cluster (GoogleCloudPlatfor…

c9841d2

…m#12002)

akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024

Add autoscaling settings to pc management cluster (GoogleCloudPlatfor…

e056bcc

…m#12002)

amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024

Add autoscaling settings to pc management cluster (GoogleCloudPlatfor…

7f2fed0

…m#12002)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add autoscaling settings to pc management cluster #12002

Add autoscaling settings to pc management cluster #12002

varshatumburu commented Oct 15, 2024 •

edited

Loading

modular-magician commented Oct 15, 2024

modular-magician commented Oct 15, 2024

modular-magician commented Oct 15, 2024

modular-magician commented Oct 15, 2024

modular-magician commented Oct 15, 2024

modular-magician commented Oct 15, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 18, 2024

modular-magician commented Oct 18, 2024

modular-magician commented Oct 18, 2024

modular-magician commented Oct 18, 2024

zli82016 commented Oct 21, 2024 •

edited

Loading

varshatumburu commented Oct 21, 2024

zli82016 commented Oct 21, 2024 •

edited

Loading

varshatumburu commented Oct 21, 2024

zli82016 commented Oct 21, 2024

modular-magician commented Oct 25, 2024

varshatumburu commented Oct 25, 2024 •

edited

Loading

modular-magician commented Oct 25, 2024

modular-magician commented Oct 25, 2024

modular-magician commented Oct 25, 2024

modular-magician commented Oct 25, 2024

modular-magician commented Oct 25, 2024

modular-magician commented Oct 25, 2024

modular-magician commented Oct 25, 2024

modular-magician commented Oct 26, 2024

modular-magician commented Oct 26, 2024

zli82016 left a comment

Add autoscaling settings to pc management cluster #12002

Add autoscaling settings to pc management cluster #12002

Conversation

varshatumburu commented Oct 15, 2024 • edited Loading

modular-magician commented Oct 15, 2024

Diff report

Missing test report

modular-magician commented Oct 15, 2024

Tests analytics

modular-magician commented Oct 15, 2024

Diff report

Missing test report

modular-magician commented Oct 15, 2024

Tests analytics

modular-magician commented Oct 15, 2024

Diff report

modular-magician commented Oct 15, 2024

Tests analytics

modular-magician commented Oct 16, 2024

Diff report

modular-magician commented Oct 16, 2024

Diff report

modular-magician commented Oct 16, 2024

Tests analytics

modular-magician commented Oct 16, 2024

Tests analytics

github-actions bot commented Oct 16, 2024

modular-magician commented Oct 16, 2024

Diff report

modular-magician commented Oct 16, 2024

Tests analytics

modular-magician commented Oct 18, 2024

Diff report

modular-magician commented Oct 18, 2024

Tests analytics

modular-magician commented Oct 18, 2024

Diff report

modular-magician commented Oct 18, 2024

Tests analytics

zli82016 commented Oct 21, 2024 • edited Loading

varshatumburu commented Oct 21, 2024

zli82016 commented Oct 21, 2024 • edited Loading

varshatumburu commented Oct 21, 2024

zli82016 commented Oct 21, 2024

modular-magician commented Oct 25, 2024

Diff report

varshatumburu commented Oct 25, 2024 • edited Loading

modular-magician commented Oct 25, 2024

Tests analytics

Action taken

modular-magician commented Oct 25, 2024

Diff report

modular-magician commented Oct 25, 2024

Diff report

modular-magician commented Oct 25, 2024

Tests analytics

Action taken

modular-magician commented Oct 25, 2024

Tests analytics

Action taken

modular-magician commented Oct 25, 2024

modular-magician commented Oct 25, 2024

modular-magician commented Oct 26, 2024

Diff report

modular-magician commented Oct 26, 2024

Tests analytics

zli82016 left a comment

Choose a reason for hiding this comment

varshatumburu commented Oct 15, 2024 •

edited

Loading

zli82016 commented Oct 21, 2024 •

edited

Loading

zli82016 commented Oct 21, 2024 •

edited

Loading

varshatumburu commented Oct 25, 2024 •

edited

Loading