Add autoscaling settings to external clusters

[varshatumburu]

Add terraform support for autoscaling in external cluster

Acceptance test logs can be found at gpaste/6064282717650944

Release Note Template for Downstream PRs (will be copied)

vmwareengine: added `autoscaling_settings` to `google_vmwareengine_cluster` resource

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2034 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 2034 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 569 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vmwareengine_cluster (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_cluster" "primary" {
  autoscaling_settings {
    autoscaling_policies {
      granted_memory_thresholds {
        scale_in  = # value needed
        scale_out = # value needed
      }
    }
  }
}

Resource: google_vmwareengine_private_cloud (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_private_cloud" "primary" {
  management_cluster {
    autoscaling_settings {
      autoscaling_policies {
        consumed_memory_thresholds {
          scale_in  = # value needed
          scale_out = # value needed
        }
        granted_memory_thresholds {
          scale_in  = # value needed
          scale_out = # value needed
        }
      }
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1017 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 1017 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 284 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vmwareengine_cluster (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vmwareengine_cluster" "primary" {
  autoscaling_settings {
    autoscaling_policies {
      granted_memory_thresholds {
        scale_in  = # value needed
        scale_out = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1025 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 1025 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 284 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1025 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 1025 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 284 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 807 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 807 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 805 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 805 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 805 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 805 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 805 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 805 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 807 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 807 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[SarahFrench]

Hi, thanks for your PR!

I'm asking the Google Terraform team if anyone can swap review of this PR with me, as there are a few blockers for me to review this as a HashiCorp employee/non-googler:

• No information about the new fields in the public API docs for me to use
• I'm unable to access the acceptance test logs you've supplied (thank you for supplying some!)
• I'm unable to run the acceptance test in our test environment to create some new logs for me to look at due to "Error code 13, message: an internal error has occurred" errors occurring

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 807 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 807 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• vmwareengine

🟢 All tests passed!

View the build log

[rileykarson]

LGTM, thanks!

I'm going to merge this and assume the nightly environments succeed. If they don't I can follow up.