Skip to content

Added google_apigee_app_group resource #12020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

apichick
Copy link
Contributor

@apichick apichick commented Oct 16, 2024

This is a PR to add the google_apigee_app_group resource

`google_apigee_app_group`

@github-actions github-actions bot requested a review from ScottSuarez October 16, 2024 15:10
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 16, 2024
@modular-magician modular-magician added service/apigee and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 16, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1072 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1072 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 152 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_app_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_app_group" "primary" {
  attributes {
    name  = # value needed
    value = # value needed
  }
  display_name = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 14
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • apigee
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeAppGroup_apigeeAppGroupBasicTestExample
    🟢 All tests passed!

View the build log

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 17, 2024
@apichick
Copy link
Contributor Author

Added tests for attributes

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 17, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1242 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1242 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 152 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_app_group (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_app_group" "primary" {
  display_name = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 45
Passed tests: 14
Skipped tests: 31
Affected tests: 0

Click here to see the affected service packages
  • apigee
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeAppGroup_apigeeAppGroupBasicTestExample
  • TestAccApigeeAppGroup_apigeeAppGroupWithAttributesTestExample
    🟢 All tests passed!

View the build log

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 17, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1246 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1246 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 152 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 45
Passed tests: 14
Skipped tests: 31
Affected tests: 0

Click here to see the affected service packages
  • apigee
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeAppGroup_apigeeAppGroupBasicTestExample
  • TestAccApigeeAppGroup_apigeeAppGroupWithAttributesTestExample
    🟢 All tests passed!

View the build log

akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants