Skip to content

add google_iam_principal_access_boundary_policy resource #12044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 5, 2024

Conversation

derekchu-google
Copy link
Contributor

@derekchu-google derekchu-google commented Oct 17, 2024

Fixes hashicorp/terraform-provider-google#19905

Release Note Template for Downstream PRs (will be copied)

`google_iam_principal_access_boundary_policy` (beta)

@github-actions github-actions bot requested a review from SarahFrench October 17, 2024 20:10
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  details {
    enforcement_version = # value needed
    rules {
      description = # value needed
      effect      = # value needed
      resources   = # value needed
    }
  }
  etag = # value needed
}

Errors

google provider:

  • Failed to build branch auto-pr-12044-old

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4198
Passed tests: 3775
Skipped tests: 418
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccDataLossPreventionDiscoveryConfig_Update
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]
🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log]
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@derekchu-google
Copy link
Contributor Author

still WIP. please hold off on review. thanks!

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4198
Passed tests: 3776
Skipped tests: 418
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
  • TestAccDataLossPreventionDiscoveryConfig_Update
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1345 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 1340 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 1350 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 1340 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log]
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4198
Passed tests: 3776
Skipped tests: 418
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
  • TestAccDataLossPreventionDiscoveryConfig_Update
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

@derekchu-google
Copy link
Contributor Author

🟢 Tests passed during RECORDING mode: TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log] TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

i tested with my own project/organization. this command is hidden behind a visibility label so I impersonated with a service account which has the proper permissions. im not sure how to reflect this testing setup in these PR tests.

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log]
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4200
Passed tests: 3778
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log]
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4200
Passed tests: 3777
Skipped tests: 420
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Error message] [Debug log]
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log]
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@SarahFrench SarahFrench changed the title add principal access boundary policy resource. Fixes https://github.com/hashicorp/terraform-provider-google/issues/19905 add google_iam3_principal_access_boundary_policy resource Oct 22, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 1350 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 1340 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4208
Passed tests: 3786
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 195 insertions(+))
google-beta provider: Diff ( 13 files changed, 1353 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_principal_access_boundary_policy (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_principal_access_boundary_policy" "primary" {
  etag = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4246
Passed tests: 3817
Skipped tests: 420
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApphubWorkload_apphubWorkloadBasicExample
  • TestAccApphubWorkload_apphubWorkloadFullExample
  • TestAccApphubWorkload_apphubWorkloadUpdate
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccDataSourceApphubDiscoveredWorkload_basic
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iamPrincipalAccessBoundaryPolicyExample
  • TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample
  • TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample
  • TestAccNetworkServicesLbTrafficExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApphubWorkload_apphubWorkloadBasicExample [Debug log]
TestAccApphubWorkload_apphubWorkloadFullExample [Debug log]
TestAccApphubWorkload_apphubWorkloadUpdate [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccDataSourceApphubDiscoveredWorkload_basic [Debug log]
TestAccIAM3PrincipalAccessBoundaryPolicy_iamPrincipalAccessBoundaryPolicyExample [Debug log]
TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample [Debug log]
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample [Debug log]
TestAccNetworkServicesLbTrafficExtension_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+))
google-beta provider: Diff ( 13 files changed, 1331 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 170 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4246
Passed tests: 3824
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_resourceManagerTags
  • TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_resourceManagerTags [Debug log]
TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_resourceManagerTags [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@derekchu-google
Copy link
Contributor Author

@SarahFrench thanks for all the reviews! please do let me know if there's additional concerns.

@SarahFrench SarahFrench changed the title add google_iam3_principal_access_boundary_policy resource add google_iam_principal_access_boundary_policy resource Nov 5, 2024
@SarahFrench
Copy link
Contributor

Re-running tests, as TestAccContainerCluster_resourceManagerTags appears to have failed due to a bootstrapping issue

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+))
google-beta provider: Diff ( 14 files changed, 1336 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 170 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4269
Passed tests: 3849
Skipped tests: 417
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample
  • TestAccNetworkManagementConnectivityTest_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample [Debug log]
TestAccNetworkManagementConnectivityTest_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 189 insertions(+))
google-beta provider: Diff ( 14 files changed, 1336 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 170 insertions(+))

@derekchu-google
Copy link
Contributor Author

thanks @SarahFrench. interesting when i ran my tests locally on the beta provider it complained about it missing from the ga provider. not sure why that was the case. anyways, appreciate you removing it if unnecessary.

@SarahFrench
Copy link
Contributor

thanks @SarahFrench. interesting when i ran my tests locally on the beta provider it complained about it missing from the ga provider. not sure why that was the case. anyways, appreciate you removing it if unnecessary.

Looks like I shouldn't have done that, as an empty file google/services/iam3/resource_iam_principal_access_boundary_policy_test.go is made in the GA provider. I'll push a change to re-add it

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4269
Passed tests: 3852
Skipped tests: 417
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+))
google-beta provider: Diff ( 14 files changed, 1336 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 170 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4270
Passed tests: 3853
Skipped tests: 417
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🟢 All tests passed!

View the build log

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add terraform resources for Principal Access Boundary policy for GCP
4 participants