Enable usage of flags related to instance mode and instance endpoints.

[shubhamdamani]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

memorystore: added `mode` flag to `google_memorystore_instance`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 36 insertions(+))
google-beta provider: Diff ( 3 files changed, 165 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  endpoints = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 36 insertions(+))
google-beta provider: Diff ( 3 files changed, 165 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  endpoints = # value needed
}

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_memorystoreInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_memorystoreInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 36 insertions(+))
google-beta provider: Diff ( 3 files changed, 165 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance" "primary" {
  endpoints = # value needed
}

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_memorystoreInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 35 insertions(+))
google-beta provider: Diff ( 3 files changed, 144 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 35 insertions(+))
google-beta provider: Diff ( 3 files changed, 144 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_memorystoreInstanceFullExample

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_memorystoreInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[c2thorn]

I don't see an "endpoints" field in https://cloud.google.com/memorystore/docs/valkey/reference/rest/v1beta/projects.locations.instances

This is a new output-only field? Does it not appear in the docs?

[shubhamdamani]

Yes, it is new output only field.
Documentation changes are executed in parallel. They will be released on the launch date, so we won't be able to see them currently in the docs. This is intended behaviour from our end.