Skip to content

Bigtable row affinity #12090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2024
Merged

Bigtable row affinity #12090

merged 3 commits into from
Nov 21, 2024

Conversation

djyau
Copy link
Contributor

@djyau djyau commented Oct 22, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigtable: added `row_affinity` field to `google_bigtable_app_profile` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 110 insertions(+))
google-beta provider: Diff ( 2 files changed, 109 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 0
Skipped tests: 50
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    🟢 All tests passed!

View the build log

ron-gal
ron-gal reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@ron-gal ron-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run VCR tests locally, as we skip them in PRs for some reason

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 110 insertions(+))
google-beta provider: Diff ( 2 files changed, 109 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 0
Skipped tests: 50
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 147 insertions(+))
google-beta provider: Diff ( 2 files changed, 146 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 147 insertions(+))
google-beta provider: Diff ( 2 files changed, 146 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 0
Skipped tests: 51
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
  • TestAccBigtableAppProfile_updateRowAffinityShort
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 0
Skipped tests: 51
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
  • TestAccBigtableAppProfile_updateRowAffinityShort
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 149 insertions(+))
google-beta provider: Diff ( 2 files changed, 148 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 6 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 0
Skipped tests: 51
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
  • TestAccBigtableAppProfile_updateRowAffinityShort
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 150 insertions(+))
google-beta provider: Diff ( 2 files changed, 149 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 0
Skipped tests: 51
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
  • TestAccBigtableAppProfile_updateRowAffinityShort
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 151 insertions(+))
google-beta provider: Diff ( 2 files changed, 150 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 0
Skipped tests: 50
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 115 insertions(+))
google-beta provider: Diff ( 2 files changed, 114 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 0
Skipped tests: 50
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    🟢 All tests passed!

View the build log

@djyau djyau force-pushed the bigtable-row-affinity branch from d0e9f37 to 87b73fd Compare November 18, 2024 17:46
@djyau djyau force-pushed the bigtable-row-affinity branch from 87b73fd to 7cbe248 Compare November 18, 2024 17:50
@djyau djyau marked this pull request as ready for review November 18, 2024 18:11
@github-actions github-actions bot requested a review from trodge November 18, 2024 18:12
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 114 insertions(+))
google-beta provider: Diff ( 2 files changed, 114 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 0
Skipped tests: 50
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    🟢 All tests passed!

View the build log

@github-actions GitHub Actions
Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 114 insertions(+))
google-beta provider: Diff ( 2 files changed, 114 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 0
Skipped tests: 50
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableAppProfile_updateRowAffinity
    🟢 All tests passed!

View the build log

@trodge trodge merged commit 38e720d into GoogleCloudPlatform:main Nov 21, 2024
13 checks passed
This was referenced Nov 21, 2024
Merged
Merged
Merged
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@djyau @amanMahendroo
Bigtable row affinity (GoogleCloudPlatform#12090)
01a76af
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
@djyau @niharika-98
Bigtable row affinity (GoogleCloudPlatform#12090)
d02c854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trodge trodge trodge approved these changes

@ron-gal ron-gal Awaiting requested review from ron-gal

Assignees
No one assigned
Labels
service/bigtableadmin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djyau @modular-magician @trodge @ron-gal