Add external catalog dataset options to google_bigquery_dataset beta

[wj-chen]

Add external catalog dataset options to google_bigquery_dataset beta

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigquery: added `external_catalog_dataset_options` fields to `google_bigquery_dataset` resource (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 117 insertions(+))
google-beta provider: Diff ( 4 files changed, 265 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 47 insertions(+))

[modular-magician]

Tests analytics

Total tests: 123
Passed tests: 111
Skipped tests: 10
Affected tests: 2

Click here to see the affected service packages

• bigquery

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryDataset_bigqueryDatasetExternalCatalogDatasetOptionsExample
• TestAccBigQueryDataset_externalCatalogDatasetOptions_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryDataset_bigqueryDatasetExternalCatalogDatasetOptionsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDataset_externalCatalogDatasetOptions_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 83 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 47 insertions(+))

[modular-magician]

Tests analytics

Total tests: 123
Passed tests: 112
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages

• bigquery

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryDataset_externalCatalogDatasetOptions_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryDataset_externalCatalogDatasetOptions_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

lgtm

[c2thorn]

Looks like a recent conflict popped up for mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go

[wj-chen]

Looks like a recent conflict popped up for mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go

Thank you for your review. I did a sync and there should be no conflict now.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 83 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 47 insertions(+))

[modular-magician]

Tests analytics

Total tests: 123
Passed tests: 113
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• bigquery

🟢 All tests passed!

View the build log

[wj-chen]

Looks like a recent conflict popped up for mmv1/third_party/terraform/services/bigquery/resource_bigquery_dataset_test.go

Thank you for your review. I did a sync and there should be no conflict now.

Had to resolve another conflict in the file, but it should be good again.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 83 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 47 insertions(+))

[modular-magician]

Tests analytics

Total tests: 123
Passed tests: 113
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• bigquery

🟢 All tests passed!

View the build log