Skip to content

Add VPC Flow Logs Config Terraform API #12161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alkobi-google
Copy link
Contributor

@alkobi-google alkobi-google commented Oct 28, 2024

Add VPC Flow Logs Config Terraform API.

`google_network_management_vpc_flow_logs_config` (beta)

@github-actions github-actions bot requested a review from NickElliot October 28, 2024 14:28
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 28, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1363 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 2049 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 168 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_management_vpc_flow_logs_config (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_management_vpc_flow_logs_config" "primary" {
  filter_expr     = # value needed
  labels          = # value needed
  metadata_fields = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4231
Passed tests: 3802
Skipped tests: 420
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample
  • TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample
  • TestAccNetworkManagementConnectivityTest_update
  • TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigInterconnectBasicExample
  • TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigInterconnectFullExample
  • TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigVpnBasicExample
  • TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigVpnFullExample
  • TestAccNetworkManagementVpcFlowLogsConfig_updateInterconnect
  • TestAccNetworkManagementVpcFlowLogsConfig_updateVpn

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample [Debug log]
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample [Debug log]
TestAccNetworkManagementConnectivityTest_update [Debug log]
TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigInterconnectBasicExample [Debug log]
TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigInterconnectFullExample [Debug log]
TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigVpnBasicExample [Debug log]
TestAccNetworkManagementVpcFlowLogsConfig_networkManagementVpcFlowLogsConfigVpnFullExample [Debug log]
TestAccNetworkManagementVpcFlowLogsConfig_updateInterconnect [Debug log]
TestAccNetworkManagementVpcFlowLogsConfig_updateVpn [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@alkobi-google
Copy link
Contributor Author

Updated the change log message to fulfill changelog-checker requirements

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change -- additionally, is this resource intended to be beta only? if so it needs a min_version: 'beta' flag

@github-actions github-actions bot requested a review from NickElliot October 31, 2024 11:34
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 31, 2024
@alkobi-google
Copy link
Contributor Author

minor change -- additionally, is this resource intended to be beta only? if so it needs a min_version: 'beta' flag

This resource is intended for GA by the end of Q1 2025, currently only supported in beta.
The tests (examples) contain the min_version: 'beta' flag

Copy link
Contributor Author

@alkobi-google alkobi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the VpcFlowLogsConfig.yaml description.
Also, the examples in VpcFlowLogsConfig.yaml contain the 'min_version: beta` flag.
This API is currently intended for beta but will be enabled for GA as well in the future (current ETA is Q1 2025)

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if support is planned Soon, it needs to be flagged as a beta only resource if the provider is releasing it as such

@github-actions github-actions bot requested a review from NickElliot November 2, 2024 14:19
Copy link
Contributor Author

@alkobi-google alkobi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated VpcFlowLogsConfig to state it's beta only by adding min_version: beta

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 4, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 436 insertions(+))
google-beta provider: Diff ( 10 files changed, 2057 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 168 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_management_vpc_flow_logs_config (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_management_vpc_flow_logs_config" "primary" {
  filter_expr     = # value needed
  labels          = # value needed
  metadata_fields = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4260
Passed tests: 3843
Skipped tests: 417
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🟢 All tests passed!

View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickElliot NickElliot merged commit 151f8f2 into GoogleCloudPlatform:main Nov 4, 2024
15 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants