-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add VPC Flow Logs Config Terraform API #12161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VPC Flow Logs Config Terraform API #12161
Conversation
Signed-off-by: alkobi-google <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
…t_full test Signed-off-by: alkobi-google <[email protected]>
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_management_vpc_flow_logs_config" "primary" {
filter_expr = # value needed
labels = # value needed
metadata_fields = # value needed
}
|
Tests analyticsTotal tests: 4231 Click here to see the affected service packages
Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
Updated the change log message to fulfill changelog-checker requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change -- additionally, is this resource intended to be beta only? if so it needs a min_version: 'beta'
flag
This resource is intended for GA by the end of Q1 2025, currently only supported in beta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the VpcFlowLogsConfig.yaml description.
Also, the examples in VpcFlowLogsConfig.yaml contain the 'min_version: beta` flag.
This API is currently intended for beta but will be enabled for GA as well in the future (current ETA is Q1 2025)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if support is planned Soon, it needs to be flagged as a beta only resource if the provider is releasing it as such
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated VpcFlowLogsConfig to state it's beta only by adding min_version: beta
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_management_vpc_flow_logs_config" "primary" {
filter_expr = # value needed
labels = # value needed
metadata_fields = # value needed
}
|
Tests analyticsTotal tests: 4260 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: alkobi-google <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
Signed-off-by: alkobi-google <[email protected]>
Add VPC Flow Logs Config Terraform API.