Skip to content

Support sub-CA to be activated into staged state #12162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

gfxcc
Copy link
Contributor

@gfxcc gfxcc commented Oct 28, 2024

b/374108917

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

privateca: added support for sub-CA to be activated into STAGED state

@gfxcc gfxcc marked this pull request as ready for review October 28, 2024 17:06
@github-actions github-actions bot requested a review from SirGitsalot October 28, 2024 17:07
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 164 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 164 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 40
Passed tests: 32
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • privateca
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreationInStagedState
    🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants