Skip to content

fix(apigee): Added in-place update of google_apigee_environment resource #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

entertvl
Copy link
Contributor

@entertvl entertvl commented Oct 29, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

apigee: added in-place update of `google_apigee_environment` resource

@github-actions github-actions bot requested a review from hao-nan-li October 29, 2024 10:48
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 29, 2024
@entertvl entertvl changed the title fix(apigee): Added in-place update of google_apigee_instance resource fix(apigee): Added in-place update of google_apigee_environment resource Oct 29, 2024
@entertvl entertvl force-pushed the fix-apigee-update-environment branch from 3d885ed to 5f603ce Compare October 29, 2024 10:51
@modular-magician modular-magician added service/apigee and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 29, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 137 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 137 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 48
Passed tests: 14
Skipped tests: 34
Affected tests: 0

Click here to see the affected service packages
  • apigee
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest
    🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from hao-nan-li October 31, 2024 05:41
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 31, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 136 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 136 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 14
Skipped tests: 34
Affected tests: 1

Click here to see the affected service packages
  • apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@entertvl entertvl requested a review from hao-nan-li November 5, 2024 10:45
@hao-nan-li hao-nan-li merged commit f97d7e0 into GoogleCloudPlatform:main Nov 5, 2024
14 checks passed
@entertvl entertvl deleted the fix-apigee-update-environment branch November 5, 2024 23:55
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating apigee environment description forces a recreation of the apigee environment
3 participants