feat: Add disks support to compute_node_template

[jjtroberts]

This PR adds Local SSD disk settings support.

Fixes hashicorp/terraform-provider-google#20026

compute: added `disks` field to `google_compute_node_template` resource

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 164 insertions(+))
google-beta provider: Diff ( 2 files changed, 164 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 54 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_node_template (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_node_template" "primary" {
  disks {
    disk_count   = # value needed
    disk_size_gb = # value needed
    disk_type    = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1046
Passed tests: 973
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 164 insertions(+))
google-beta provider: Diff ( 2 files changed, 164 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 54 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_node_template (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_node_template" "primary" {
  disks {
    disk_count   = # value needed
    disk_size_gb = # value needed
    disk_type    = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1048
Passed tests: 975
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 234 insertions(+))
google-beta provider: Diff ( 3 files changed, 234 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 54 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1049
Passed tests: 975
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeNodeTemplate_nodeTemplateDisksExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeNodeTemplate_nodeTemplateDisksExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 234 insertions(+))
google-beta provider: Diff ( 3 files changed, 234 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 54 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 116 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1059
Passed tests: 986
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[zli82016]

LGTM

[zli82016]

LGTM