Skip to content

Added controlled-vault feature to backupdr-backupvault #12239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

liyun-huang
Copy link
Member

@liyun-huang liyun-huang commented Nov 4, 2024

backupdr: added `access_restriction` field to`google_backup_dr_backup_vault` resource (beta)

@github-actions github-actions bot requested a review from slevenick November 4, 2024 21:37
Copy link

github-actions bot commented Nov 4, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 4 files changed, 27 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 1
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • backupdr

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_backupDrBackupVaultFullExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccDataSourceGoogleBackupDRBackupPlan_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccBackupDRBackupVault_backupDrBackupVaultFullExample [Error message] [Debug log]
TestAccBackupDRBackupVault_fullUpdate [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@liyun-huang liyun-huang closed this Nov 4, 2024
@liyun-huang liyun-huang reopened this Nov 4, 2024
@liyun-huang liyun-huang marked this pull request as draft November 4, 2024 22:27
@liyun-huang
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 4 files changed, 47 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 4 files changed, 47 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 1
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • backupdr

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_backupDrBackupVaultFullExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccDataSourceGoogleBackupDRBackupPlan_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 4 files changed, 47 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 1
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • backupdr

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_backupDrBackupVaultFullExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccDataSourceGoogleBackupDRBackupPlan_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_backupDrBackupVaultFullExample [Debug log]
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_backupDrBackupVaultFullExample [Debug log]
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlan_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 4 files changed, 47 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 4
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@liyun-huang liyun-huang marked this pull request as ready for review November 4, 2024 22:58
@liyun-huang
Copy link
Member Author

TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample failed test is not relevant to changed files.

@liyun-huang liyun-huang changed the title Main Added controlled-vault feature to backupdr-backupvault Nov 4, 2024
@github-actions github-actions bot requested a review from slevenick November 5, 2024 16:19
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 4 files changed, 38 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5
Passed tests: 3
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • backupdr

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@liyun-huang
Copy link
Member Author

@slevenick Hi Sam, please let me know if there are anything I should address for this PR. Thanks!

Copy link

github-actions bot commented Nov 8, 2024

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants