-
Notifications
You must be signed in to change notification settings - Fork 1.8k
compute: used net.IP.Equal
vs bytes.Equal
for IP comparison
#12279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute: used net.IP.Equal
vs bytes.Equal
for IP comparison
#12279
Conversation
Resolves lint warning: SA1021: use net.IP.Equal to compare net.IPs, not bytes.Equal
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
net.IP.Equal
vs bytes.Equal
for IP comparisonnet.IP.Equal
vs bytes.Equal
for IP comparison
Tests analyticsTotal tests: 1060 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Resolves a lint warning and removes an extra import:
SA1021: use net.IP.Equal to compare net.IPs, not bytes.Equal
https://staticcheck.dev/docs/checks#SA1021 explains the reasoning a bit more.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.