Skip to content

Add new resource iam_projects_policy_binding. addresses https://github.com/hashicorp/terraform-provider-google/issues/20198 #12302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 21, 2024
Merged

Add new resource iam_projects_policy_binding. addresses https://github.com/hashicorp/terraform-provider-google/issues/20198 #12302

merged 6 commits into from
Nov 21, 2024

Conversation

derekchu-google
Copy link
Contributor 

`google_iam_projects_policy_binding` (beta)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 242 insertions(+))
google-beta provider: Diff ( 9 files changed, 1490 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 197 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_projects_policy_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_projects_policy_binding" "primary" {
  annotations = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • iam3

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample
  • TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample [Error message] [Debug log]
TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 229 insertions(+))
google-beta provider: Diff ( 11 files changed, 1440 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 197 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_projects_policy_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_projects_policy_binding" "primary" {
  annotations = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • iam3

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample
  • TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample [Error message] [Debug log]
TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@derekchu-google derekchu-google marked this pull request as ready for review November 15, 2024 16:35
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from rileykarson November 15, 2024 16:36
@derekchu-google
Copy link
Contributor Author

hi there @rileykarson, this PR is ready to go. please take a look

@github-actions GitHub Actions
Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 231 insertions(+))
google-beta provider: Diff ( 10 files changed, 1308 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 197 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_projects_policy_binding (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_projects_policy_binding" "primary" {
  annotations = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 6
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • iam3

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample
  • TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample [Debug log]
TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 231 insertions(+))
google-beta provider: Diff ( 10 files changed, 1309 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 197 insertions(+))

rileykarson
rileykarson reviewed Nov 20, 2024
View reviewed changes
mmv1/products/iam3/ProjectsPolicyBinding.yaml Outdated
Output only. The globally unique ID of the policy binding. Assigned when the policy binding is created.
output: true
- name: 'etag'
type: String
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should omit this or make it the (unfortunately underdocumented...) Fingerprint type:

magic-modules/mmv1/api/type.go

Line 705 in d5e86ba

case "Fingerprint":

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know. will do

mmv1/third_party/terraform/services/iam3/resource_iam_projects_policy_binding_test.go.tmpl
ImportStateVerifyIgnore: []string{"annotations", "location", "policy_binding_id"},
},
{
Config: testAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update(context),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a third step where we go back to testAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_full afterwards?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • iam3

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from rileykarson November 20, 2024 21:43
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 231 insertions(+))
google-beta provider: Diff ( 10 files changed, 1338 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 207 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • iam3

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAM3ProjectsPolicyBinding_iamProjectsPolicyBindingExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@rileykarson rileykarson merged commit bd1c0c0 into GoogleCloudPlatform:main Nov 21, 2024
15 checks passed
This was referenced Nov 21, 2024
Merged
Merged
Merged
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@derekchu-google @amanMahendroo
Add new resource iam_projects_policy_binding. addresses hashicorp/ter…
eae8158 
…raform-provider-google#20198 (GoogleCloudPlatform#12302)
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
@derekchu-google @niharika-98
Add new resource iam_projects_policy_binding. addresses hashicorp/ter…
da6cbee 
…raform-provider-google#20198 (GoogleCloudPlatform#12302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

@priyankadeo-g priyankadeo-g priyankadeo-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derekchu-google @modular-magician @rileykarson @priyankadeo-g