Skip to content

fix: derive the project attribute from resource or compute api or fallback to provider #12305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gurusai-voleti
Copy link
Contributor

@gurusai-voleti gurusai-voleti commented Nov 12, 2024

Fixes hashicorp/terraform-provider-google#17165
Fixes hashicorp/terraform-provider-google#8977

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: derive the project attribute from resource or compute api or fallback to provider in `resource_storage_bucket`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 1 file changed, 7 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 109
Passed tests: 100
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • storage

🟢 All tests passed!

View the build log

@gurusai-voleti gurusai-voleti marked this pull request as ready for review November 13, 2024 11:57
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from SirGitsalot November 13, 2024 11:58
Copy link
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the code change, but please update the docs too:

https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/d/storage_bucket.html.markdown

The "If no value is supplied in the configuration or through provider defaults then the data source will use the Compute API..." is not accurate anymore

@github-actions github-actions bot requested a review from SirGitsalot November 15, 2024 06:37
@gurusai-voleti
Copy link
Contributor Author

LGTM for the code change, but please update the docs too:

https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/d/storage_bucket.html.markdown

The "If no value is supplied in the configuration or through provider defaults then the data source will use the Compute API..." is not accurate anymore

Updated documentation

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 2 files changed, 8 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 109
Passed tests: 100
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • storage

🟢 All tests passed!

View the build log

@SirGitsalot SirGitsalot merged commit c09b302 into GoogleCloudPlatform:main Nov 15, 2024
12 checks passed
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants