Skip to content

Add Code Repository Index resource #12338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JumiDeluxe
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Add new resources for Gemini Code Assist

`google_gemini_code_repository_index`

Copy link

github-actions bot commented Nov 15, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau November 15, 2024 17:18
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 166 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 1098 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4294
Passed tests: 3882
Skipped tests: 410
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccGeminiCodeRepositoryIndex_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the code-repository-index branch from f9fb977 to bbddff0 Compare November 15, 2024 20:17
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 166 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 1092 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4297
Passed tests: 3885
Skipped tests: 410
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccGeminiCodeRepositoryIndex_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the code-repository-index branch 2 times, most recently from 74dbf62 to 4c107d3 Compare November 18, 2024 12:10
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 166 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 1094 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4300
Passed tests: 3889
Skipped tests: 410
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiCodeRepositoryIndex_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the code-repository-index branch from 4c107d3 to f0e0bfe Compare November 18, 2024 15:15
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 166 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 14 files changed, 1094 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

@melinath melinath requested review from a team, SirGitsalot and BBBmau and removed request for BBBmau, a team and SirGitsalot November 18, 2024 16:28
@melinath
Copy link
Member

Reassigning this review

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4300
Passed tests: 3889
Skipped tests: 410
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiCodeRepositoryIndex_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the code-repository-index branch from 2f435b1 to f9077ea Compare November 22, 2024 11:59
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 166 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 13 files changed, 1035 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 166 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 13 files changed, 1033 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4312
Passed tests: 3903
Skipped tests: 407
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccGeminiCodeRepositoryIndex_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4312
Passed tests: 3903
Skipped tests: 407
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccGeminiCodeRepositoryIndex_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@melinath melinath removed the request for review from Prytu November 22, 2024 16:24
@melinath
Copy link
Member

Drive-by comment: It looks like there's inconsistency in terms of calling the service gemini vs cloudaicompanion. Generally speaking we recommend using the API subdomain (cloudaicompanion) because it is not mutable - but if you use gemini instead, you should use it consistently to avoid confusion. So for example, the products folder should also be called gemini.

You also don't need to have both gemini and cloudaicompanion listed in the teamcity services - only the one that you end up choosing.

@JumiDeluxe
Copy link
Member Author

I've renamed services for consistency by following the resources naming

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 156 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 13 files changed, 1033 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4313
Passed tests: 3904
Skipped tests: 407
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@SirGitsalot
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 156 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 13 files changed, 1033 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4316
Passed tests: 3906
Skipped tests: 407
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
  • TestAccParallelstoreInstance_parallelstoreInstanceBasicExample
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants