Skip to content

add server-side id for a few resources #12351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2024
Merged

add server-side id for a few resources #12351

merged 4 commits into from
Nov 20, 2024

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Nov 18, 2024 •
edited
Loading

closes hashicorp/terraform-provider-google#20223

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added server generated id as `forwarding_rule_id` to `google_compute_global_forwarding_rule`

compute: added server generated id as `health_check_id` to `google_region_health_check`

compute: added server generated id as `instance_group_manager_id` to `google_region_instance_group_manager`

compute: added server generated id as `instance_group_manager_id` to `google_instance_group_manager`

compute: added server generated id as `network_endpoint_id` to `google_region_network_endpoint`

compute: added server generated id as `subnetwork_id` to `google_subnetwork`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 153 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 13 files changed, 157 insertions(+), 31 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • compute

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 127 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 127 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1064
Passed tests: 989
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccInstanceGroupManager_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]
TestAccInstanceGroupManager_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 130 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 130 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1064
Passed tests: 988
Skipped tests: 73
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccInstanceGroupManager_basic
  • TestAccRegionInstanceGroupManager_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]
TestAccInstanceGroupManager_basic [Error message] [Debug log]
TestAccRegionInstanceGroupManager_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 150 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 150 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1064
Passed tests: 990
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ScottSuarez ScottSuarez requested review from a team and shuyama1 and removed request for a team November 19, 2024 21:26
@ScottSuarez
Copy link
Contributor Author

/gcbrun

1 similar comment
@ScottSuarez
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 150 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 150 insertions(+), 2 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 150 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 150 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1064
Passed tests: 989
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1064
Passed tests: 990
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ScottSuarez
Copy link
Contributor Author

@shuyama1 this should be ready for review. Failing test is unrelated.

@shuyama1
Copy link
Member

@shuyama1 this should be ready for review. Failing test is unrelated.

yeah, looks like it's failed at main already

@ScottSuarez ScottSuarez merged commit b311e8a into GoogleCloudPlatform:main Nov 20, 2024
13 of 14 checks passed
This was referenced Nov 20, 2024
Merged
Merged
Merged
@wyardley wyardley mentioned this pull request Nov 20, 2024
Closed
@wyardley wyardley mentioned this pull request Dec 2, 2024
Open
wyardley added a commit to wyardley/magic-modules that referenced this pull request Dec 2, 2024
@wyardley
compute: added subnetwork_id to compute subnet data source
efea475 
Added `subnetwork_id` to `google_compute_subnetwork` data source

Picked from GoogleCloudPlatform#12285
Followup to GoogleCloudPlatform#12351
Related to hashicorp/terraform-provider-google#20223
This was referenced Dec 2, 2024
Merged
Merged
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@ScottSuarez @amanMahendroo
add server-side id for a few resources (GoogleCloudPlatform#12351)
79c1c67
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
@ScottSuarez @niharika-98
add server-side id for a few resources (GoogleCloudPlatform#12351)
eec0174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees
No one assigned
Labels
service/terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

numeric id required for tag binding is missing on many resources
3 participants
@ScottSuarez @modular-magician @shuyama1