compute: Implement graceful switch for metadata_startup_script

[Asiderr]

This patch checks whether a graceful switch (without ForceNew) is available between metadata_startup_script and metadata.startup-script. Graceful switch can be executed in two situations:

1. When metadata_startup_script is created with the old value of metadata.startup-script.
2. When metadata_startup_script is deleted and the old value remains in metadata.startup-script.

For all other changes in metadata_startup_script, isGracefulMetadataStartupSwitch sets ForceNew.

The change is covered by:
TestAccComputeInstance_metadataStartupScript_update and TestAccComputeInstance_metadataStartupScript_gracefulSwitch

closes: hashicorp/terraform-provider-google#9459

compute: made `metadata_startup_script` able to be updated via graceful switch in `google_compute_instance`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 49 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 49 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  metadata_startup_script = # value needed
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  metadata_startup_script = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1064
Passed tests: 990
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[c2thorn]

Hi @Asiderr
Did you test the Forcenew/regular update by hand?

Should we not get a new update test specifically for updating metadata_startup_script without Forcenew?

[Asiderr]

Hi @c2thorn

Did you test the Forcenew/regular update by hand?

Yes, I tested all of the potential configurations and it works as expected.

Should we not get a new update test specifically for updating metadata_startup_script without Forcenew?

I've added test TestAccComputeInstance_metadataStartupScript_gracefulSwitch that covers updating metadata_startup_script without Forcenew

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 120 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 120 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  metadata_startup_script = # value needed
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  metadata_startup_script = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1067
Passed tests: 993
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstance_metadataStartupScript_gracefulSwitch

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInstance_metadataStartupScript_gracefulSwitch [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

LGTM thanks @Asiderr for the update test.
Logic looks good for the forcenew function and should be otherwise safe considering the previous logic was always ForceNew