-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Ensure oneOf condition is honored when expanding the job configs #12378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 65 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 65 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change potentially causing any impact on the customers?
This should not cause any regression. Earlier config actually did not allow job submission with only query_file_uri set to it should unblock the customers having that issue. This explicitly does not allow setting both the fields when expanding which is expected from schema. |
Ensure oneOf condition is honored when expanding the job configuration for Hive, Pig, Spark-sql, and Presto. The change ensures that only one of
query_file_uri
orquery_list
is set when expanding job config.Fixes: hashicorp/terraform-provider-google#13278
Release Note Template for Downstream PRs (will be copied)