Skip to content

Ensure oneOf condition is honored when expanding the job configs #12378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ahzaz
Copy link
Contributor

@ahzaz ahzaz commented Nov 21, 2024

Ensure oneOf condition is honored when expanding the job configuration for Hive, Pig, Spark-sql, and Presto. The change ensures that only one of query_file_uri or query_list is set when expanding job config.

Fixes: hashicorp/terraform-provider-google#13278

Release Note Template for Downstream PRs (will be copied)

dataproc: ensured oneOf condition is honored when expanding the job configuration for Hive, Pig, Spark-sql, and Presto in `google_dataproc_job`.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 76 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 2 files changed, 76 insertions(+), 25 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 65
Passed tests: 57
Skipped tests: 6
Affected tests: 2

Click here to see the affected service packages
  • dataproc

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocJob_SparkSql_QueryFile
  • TestAccDataprocJob_SparkSql_QueryList

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 76 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 2 files changed, 76 insertions(+), 25 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 65
Passed tests: 57
Skipped tests: 6
Affected tests: 2

Click here to see the affected service packages
  • dataproc

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocJob_SparkSql_QueryFile
  • TestAccDataprocJob_SparkSql_QueryList

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocJob_SparkSql_QueryFile [Debug log]
TestAccDataprocJob_SparkSql_QueryList [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocJob_SparkSql_QueryFile [Debug log]
TestAccDataprocJob_SparkSql_QueryList [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@ahzaz ahzaz marked this pull request as ready for review November 21, 2024 13:23
@github-actions github-actions bot requested a review from hao-nan-li November 21, 2024 13:24
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change potentially causing any impact on the customers?

@ahzaz
Copy link
Contributor Author

ahzaz commented Nov 22, 2024

Is this change potentially causing any impact on the customers?

This should not cause any regression. Earlier config actually did not allow job submission with only query_file_uri set to it should unblock the customers having that issue. This explicitly does not allow setting both the fields when expanding which is expected from schema.

@github-actions github-actions bot requested a review from hao-nan-li November 22, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataproc Job creation fails for Spark SQL job with query_file_uri set
3 participants