-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add Authz Extension and Authz Policy resources #12379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_security_authz_policy" "primary" {
custom_provider {
cloud_iap {
enabled = # value needed
}
}
labels = # value needed
}
Resource: resource "google_network_services_authz_extension" "primary" {
labels = # value needed
metadata = # value needed
wire_format = # value needed
}
|
Tests analyticsTotal tests: 96 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_security_authz_policy" "primary" {
custom_provider {
cloud_iap {
enabled = # value needed
}
}
http_rules {
from {
not_sources {
principals {
contains = # value needed
exact = # value needed
ignore_case = # value needed
prefix = # value needed
suffix = # value needed
}
resources {
iam_service_account {
contains = # value needed
exact = # value needed
ignore_case = # value needed
prefix = # value needed
suffix = # value needed
}
tag_value_id_set {
ids = # value needed
}
}
}
sources {
principals {
contains = # value needed
exact = # value needed
ignore_case = # value needed
prefix = # value needed
suffix = # value needed
}
resources {
iam_service_account {
contains = # value needed
exact = # value needed
ignore_case = # value needed
prefix = # value needed
suffix = # value needed
}
tag_value_id_set {
ids = # value needed
}
}
}
}
to {
operations {
header_set {
headers {
name = # value needed
value {
contains = # value needed
exact = # value needed
ignore_case = # value needed
prefix = # value needed
suffix = # value needed
}
}
}
hosts {
contains = # value needed
exact = # value needed
ignore_case = # value needed
prefix = # value needed
suffix = # value needed
}
methods = # value needed
paths {
contains = # value needed
exact = # value needed
ignore_case = # value needed
prefix = # value needed
suffix = # value needed
}
}
}
when = # value needed
}
}
|
Tests analyticsTotal tests: 96 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_security_authz_policy" "primary" {
custom_provider {
cloud_iap {
enabled = # value needed
}
}
}
|
Tests analyticsTotal tests: 102 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
Hello folks.
This PR is to add 2 (two) new resources to the terraform MMv1:
google_network_services_authz_extension
)google_network_security_authz_policy
)Note: The
Authz Policy
resource has one field calledcloudIap
wich is an object without fields. So to make it work on terraform/yaml I needed to add one property calledenabled
that will be converted to the cloudIap field. You can check this field on the api page.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.