Skip to content

Update Stream.yaml to add cdc method support for MySQL #12465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 23, 2024

Conversation

ravijaingit
Copy link
Contributor

@ravijaingit ravijaingit commented Dec 2, 2024

This PR adds support for creating streams for MySQL source which uses gtid based replication cdc method.
Fixes : hashicorp/terraform-provider-google#20383

Release Note Template for Downstream PRs (will be copied)

datastream: added `gtid`, `binaryLogPosition` fields to `datastream_stream` resource

This adds support for creating streams for MySQL source which uses gtid based replication cdc method
@github-actions github-actions bot requested a review from ScottSuarez December 2, 2024 11:29
Copy link

github-actions bot commented Dec 2, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

This PR adds support for creating streams for MySQL source which uses gtid based replication cdc method.
Bug link: [20383](hashicorp/terraform-provider-google#20383)

Release Note Template for Downstream PRs (will be copied)

See [Write release notes](https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/) for guidance.

```
Add support for selecting gtid based replication method for MySQL source 
```
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 54 insertions(+))
google-beta provider: Diff ( 2 files changed, 54 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  source_config {
    mysql_source_config {
      binary_log_position = # value needed
      gtid                = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 54 insertions(+))
google-beta provider: Diff ( 2 files changed, 54 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  source_config {
    mysql_source_config {
      binary_log_position = # value needed
      gtid                = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

This PR adds support for creating streams for MySQL source which uses gtid based replication cdc method.
Fixes : [hashicorp/terraform-provider-google#20383](hashicorp/terraform-provider-google#20383)

Release Note Template for Downstream PRs (will be copied)

```release-note:enhancement
datastream: added `gtid`, `binaryLogPosition` fields to `datastream_stream` resource
```
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 58 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 58 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_stream (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_stream" "primary" {
  source_config {
    mysql_source_config {
      binary_log_position = # value needed
      gtid                = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 96 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 96 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test cases using this field and an update test (if the field is updatable).

@github-actions github-actions bot requested a review from ScottSuarez December 4, 2024 01:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 96 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 96 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 96 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 96 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 99 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 99 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 147 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 147 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 145 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 145 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

Copy link

github-actions bot commented Dec 6, 2024

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@ravijaingit, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions github-actions bot requested a review from ScottSuarez December 21, 2024 03:02
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 145 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 145 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

Addressed review comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 249 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 249 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datastream_stream should allow for GTID based replication
3 participants