-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update Stream.yaml to add cdc method support for MySQL #12465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds support for creating streams for MySQL source which uses gtid based replication cdc method
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This PR adds support for creating streams for MySQL source which uses gtid based replication cdc method. Bug link: [20383](hashicorp/terraform-provider-google#20383) Release Note Template for Downstream PRs (will be copied) See [Write release notes](https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/) for guidance. ``` Add support for selecting gtid based replication method for MySQL source ```
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_datastream_stream" "primary" {
source_config {
mysql_source_config {
binary_log_position = # value needed
gtid = # value needed
}
}
}
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_datastream_stream" "primary" {
source_config {
mysql_source_config {
binary_log_position = # value needed
gtid = # value needed
}
}
}
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
This PR adds support for creating streams for MySQL source which uses gtid based replication cdc method. Fixes : [hashicorp/terraform-provider-google#20383](hashicorp/terraform-provider-google#20383) Release Note Template for Downstream PRs (will be copied) ```release-note:enhancement datastream: added `gtid`, `binaryLogPosition` fields to `datastream_stream` resource ```
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_datastream_stream" "primary" {
source_config {
mysql_source_config {
binary_log_position = # value needed
gtid = # value needed
}
}
}
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test cases using this field and an update test (if the field is updatable).
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
mmv1/templates/terraform/examples/datastream_stream_mysql_gtid.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/datastream/resource_datastream_stream_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/datastream/resource_datastream_stream_test.go
Show resolved
Hide resolved
mmv1/templates/terraform/examples/datastream_stream_mysql_gtid.tf.erb
Outdated
Show resolved
Hide resolved
@ravijaingit, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Addressed review comments
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
This PR adds support for creating streams for MySQL source which uses gtid based replication cdc method.
Fixes : hashicorp/terraform-provider-google#20383
Release Note Template for Downstream PRs (will be copied)