-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support for projects in EgressSource #12532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for projects in EgressSource #12532
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
…magic-modules into acm-egress-resource
…magic-modules into acm-egress-resource
…lina612/magic-modules into acm-egress-resource" This reverts commit fe8d264, reversing changes made to 5ad22d9.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 3 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
status {
egress_policies {
egress_from {
sources {
resource = # value needed
}
}
}
}
}
}
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 3 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismiss
@Angelina612, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this feature released yet?
No, it is still in progress. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismiss review
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
Resource: resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
egress_from {
sources {
resource = # value needed
}
}
}
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
@slevenick We have rolled out the feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
43ea874
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.