Skip to content

Add group field to google_network_connectivity_spoke #12537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

septikus
Copy link
Contributor

@septikus septikus commented Dec 10, 2024

  • Add group field to Spoke resource.

Fixes hashicorp/terraform-provider-google#18297

networkconnectivity: added `group` field to `google_network_connectivity_spoke` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 December 10, 2024 20:39
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/network-connectivity-center and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 157 insertions(+))
google-beta provider: Diff ( 3 files changed, 157 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 141 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 31
Passed tests: 25
Skipped tests: 1
Affected tests: 5

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivitySpoke_InterconnectAttachmentHandWrittenHandWritten
  • TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
  • TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
  • TestAccNetworkConnectivitySpoke_VPNTunnelHandWrittenHandWritten
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkGroupExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivitySpoke_InterconnectAttachmentHandWrittenHandWritten [Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten [Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm [Debug log]
TestAccNetworkConnectivitySpoke_VPNTunnelHandWrittenHandWritten [Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkGroupExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016
Copy link
Member

Is there a Github issue for this PR?

@septikus
Copy link
Contributor Author

Is there a Github issue for this PR?

hashicorp/terraform-provider-google#18297

@github-actions github-actions bot requested a review from zli82016 December 12, 2024 19:29
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 12, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 148 insertions(+))
google-beta provider: Diff ( 3 files changed, 148 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 141 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 31
Passed tests: 25
Skipped tests: 1
Affected tests: 5

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivitySpoke_InterconnectAttachmentHandWrittenHandWritten
  • TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
  • TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
  • TestAccNetworkConnectivitySpoke_VPNTunnelHandWrittenHandWritten
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkGroupExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivitySpoke_InterconnectAttachmentHandWrittenHandWritten [Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten [Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm [Debug log]
TestAccNetworkConnectivitySpoke_VPNTunnelHandWrittenHandWritten [Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkGroupExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing spoke.group argument in google_network_connectivity_spoke resource
3 participants