Fix diff suppress function ignoring additive_vpc_scope_dns_domain in Autopilot clusters

[Michcioperz]

self-appointed successor to #11744

GKE Autopilot allows setting additive VPC scope domain on creation only. However, current implementation of the diff suppress function for Autopilot clusters removes any values in dns_config of Autopilot clusters, all the time.

This change permits setting additive VPC scope domain.

Remaining action items:

• validate that allowing dns_config.# doesn't cause issues (it seems necessary for dns_config.0.additive_vpc_scope_dns_domain to exist
• revise test coverage to look for other gaps
• verify that the change in Autopilot Suppressed Diff Prevents using additive_vpc_scope_dns_domain #11744 to ForceNew when domain changes is exactly the behavior we want and copy it over
• write the release note below

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: fixed `additive_vpc_scope_dns_domain` being ignored in Autopilot cluster definition

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 148 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 148 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 221
Passed tests: 192
Skipped tests: 12
Affected tests: 17

Click here to see the affected service packages

• container

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerClusterCustomServiceAccount_withAutopilot
• TestAccContainerCluster_autopilot_minimal
• TestAccContainerCluster_autopilot_net_admin
• TestAccContainerCluster_autopilot_withAdditiveVPC
• TestAccContainerCluster_autopilot_withDNSConfig
• TestAccContainerCluster_enableCiliumPolicies_withAutopilot
• TestAccContainerCluster_withAutopilot
• TestAccContainerCluster_withAutopilotGcpFilestoreCsiDriver
• TestAccContainerCluster_withAutopilotKubeletConfig
• TestAccContainerCluster_withAutopilotNetworkTags
• TestAccContainerCluster_withAutopilotResourceManagerTags
• TestAccContainerCluster_withAutopilot_withNodePoolDefaults
• TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot
• TestAccContainerCluster_withCgroupMode
• TestAccContainerCluster_withCgroupModeUpdate
• TestAccContainerCluster_withWorkloadALTSConfigAutopilot
• TestAccContainerCluster_withWorkloadIdentityConfigAutopilot

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_autopilot_withAdditiveVPC [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccContainerClusterCustomServiceAccount_withAutopilot [Error message] [Debug log]
TestAccContainerCluster_autopilot_minimal [Error message] [Debug log]
TestAccContainerCluster_autopilot_net_admin [Error message] [Debug log]
TestAccContainerCluster_autopilot_withDNSConfig [Error message] [Debug log]
TestAccContainerCluster_enableCiliumPolicies_withAutopilot [Error message] [Debug log]
TestAccContainerCluster_withAutopilot [Error message] [Debug log]
TestAccContainerCluster_withAutopilotGcpFilestoreCsiDriver [Error message] [Debug log]
TestAccContainerCluster_withAutopilotKubeletConfig [Error message] [Debug log]
TestAccContainerCluster_withAutopilotNetworkTags [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccContainerCluster_withAutopilot_withNodePoolDefaults [Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot [Error message] [Debug log]
TestAccContainerCluster_withCgroupMode [Error message] [Debug log]
TestAccContainerCluster_withCgroupModeUpdate [Error message] [Debug log]
TestAccContainerCluster_withWorkloadALTSConfigAutopilot [Error message] [Debug log]
TestAccContainerCluster_withWorkloadIdentityConfigAutopilot [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 207 insertions(+))
google-beta provider: Diff ( 2 files changed, 207 insertions(+))

[modular-magician]

Tests analytics

Total tests: 222
Passed tests: 207
Skipped tests: 12
Affected tests: 3

Click here to see the affected service packages

• container

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_autopilot_withAdditiveVPCMutation
• TestAccContainerCluster_autopilot_withDNSConfig
• TestAccContainerCluster_withResourceUsageExportConfig

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_autopilot_withDNSConfig [Debug log]
TestAccContainerCluster_withResourceUsageExportConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_autopilot_withAdditiveVPCMutation [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 210 insertions(+))
google-beta provider: Diff ( 2 files changed, 210 insertions(+))

[modular-magician]

Tests analytics

Total tests: 222
Passed tests: 209
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_autopilot_withAdditiveVPCMutation

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_autopilot_withAdditiveVPCMutation [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[Michcioperz]

Is @modular-magician on vacation? 😅

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[slevenick]

Huh, something is off here. There isn't a build I can approve to trigger generation. Are you up to date with the main branch of this repo?

[Michcioperz]

Seems like recreating the commit helped? Even though the parent commit hasn't changed

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 210 insertions(+))
google-beta provider: Diff ( 2 files changed, 210 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 210 insertions(+))
google-beta provider: Diff ( 2 files changed, 210 insertions(+))

[modular-magician]

Tests analytics

Total tests: 222
Passed tests: 209
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_autopilot_withAdditiveVPCMutation

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 222
Passed tests: 209
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_autopilot_withAdditiveVPCMutation

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_autopilot_withAdditiveVPCMutation [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[Michcioperz]

@slevenick I think it's looking better now, PTAL.

I know I put an action item to look for more test gaps in the PR description, but I'll file a followup bug internally for this. I think the dns config mutation test I added should be useful enough for now.

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_autopilot_withAdditiveVPCMutation [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

Rerolling reviewer as I'm out sick

[Michcioperz]

Thanks, hope you get well soon!