Apply maintenance policy updates after upgrades so validation on maintenance policy uses the new versions.

[cslink]

Switch the ordering of updates so maintenance policy updates get applied after upgrades. This means that validation on maintenance exclusions will use the new version as opposed to the old version which means you can upgrade to a new version and set an exclusion until end of support for the new version in one terraform apply command.

Fixes hashicorp/terraform-provider-google#20556

Release note:

container: changed `google_container_cluster` to apply maintenance policy updates after upgrades during cluster update

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[c2thorn]

@cslink I'd recommend following the initial steps here to get automatic build runs for any future pull requests: go/terraform-contribution-guide#before-you-begin

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 30 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 1 file changed, 30 insertions(+), 29 deletions(-))

[modular-magician]

Tests analytics

Total tests: 219
Passed tests: 206
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_resourceManagerTags

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_resourceManagerTags [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_resourceManagerTags [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🟢 All tests passed!

View the build log or the debug log for each test

[c2thorn]

retrying the test

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 30 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 1 file changed, 30 insertions(+), 29 deletions(-))

[modular-magician]

Tests analytics

Total tests: 219
Passed tests: 207
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages

• container

🟢 All tests passed!

View the build log

[c2thorn]

slightly tweaked the release notes, but PR LGTM. Thanks @cslink