Skip to content

Fixes boolean fields in the ShieldedInstanceConfig struct for dataproc clusters #12671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

satyakommula96
Copy link
Contributor

@satyakommula96 satyakommula96 commented Dec 31, 2024

Fixes hashicorp/terraform-provider-google#20203

dataproc: fixed boolean fields in the `shielded_instance_config` 

Copy link

google-cla bot commented Dec 31, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from trodge December 31, 2024 09:20
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 31, 2024
@satyakommula96 satyakommula96 changed the title Handling of boolean fields in the ShieldedInstanceConfig struct for dataproc clusters Fixes boolean fields in the ShieldedInstanceConfig struct for dataproc clusters Dec 31, 2024
@satyakommula96
Copy link
Contributor Author

@trodge could you please review this. Thanks 😃

Copy link

github-actions bot commented Jan 3, 2025

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/dataproc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 6, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 45 insertions(+))
google-beta provider: Diff ( 2 files changed, 45 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 67
Passed tests: 61
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • dataproc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocCluster_withShieldedConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocCluster_withShieldedConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shielded_instance_config values are not honoured when field values are set to "false"
3 participants