Add support for the metricsGcpServiceAccountEmail field in ConfigManagement Fleet-level default config

[terlar]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

gkehub2: added support for `fleet_default_member_config.config_management.config_sync.metrics_gcp_service_account_email` field to `google_gke_hub_feature` resource

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 27 insertions(+))
google-beta provider: Diff ( 3 files changed, 27 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 13
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🟢 All tests passed!

View the build log or the debug log for each test

[terlar]

Not sure how the testing of these fields work, so omitted the test. I did not have access to the logs, so was hard to determine what was wrong. I guess it is not enough to just add it to the VCR test. Recording worked, but the replaying didn't...

If you want this new field to be part of a test, please shed light on where/how you would like it to be tested.

Update:
or the failure was actually a data resource test, so not the test I committed, perhaps I should revert that back. Will have to investigate/understand what is going on with the data source test though.

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[terlar]

I tried running the failed VCR test locally (TestAccDataSourceGoogleGkeHubFeature_basic) and received no errors. Perhaps this is expected?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 27 insertions(+))
google-beta provider: Diff ( 3 files changed, 27 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 13
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

/gcbrun

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 27 insertions(+))
google-beta provider: Diff ( 3 files changed, 27 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 13
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

sorry for the extremely delayed review, the test failure was somewhat misleading. LGTM!

[terlar]

I just noticed that this field was deprecated for configmanagement.config_sync.metrics_gcp_service_account_email in google_gke_hub_feature_membership:
#12392

And also within the API:
https://cloud.google.com/kubernetes-engine/enterprise/config-sync/docs/reference/gcloud-apply-fields#config_sync

So I guess the timing was not the best...