Skip to content

Colab runtime template #12706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jan 13, 2025

Conversation

bcreddy-gcp
Copy link
Contributor

@bcreddy-gcp bcreddy-gcp commented Jan 8, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_colab_runtime_template`

@github-actions github-actions bot requested a review from c2thorn January 8, 2025 00:16
Copy link

github-actions bot commented Jan 8, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 1797 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1797 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 364 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 1797 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1797 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 364 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

@bcreddy-gcp bcreddy-gcp changed the title [DRAFT] Colab runtime template Colab runtime template Jan 8, 2025
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4408
Passed tests: 3975
Skipped tests: 428
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1793 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 14 files changed, 1793 insertions(+), 26 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 364 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4408
Passed tests: 3975
Skipped tests: 428
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2601 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 16 files changed, 2591 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 739 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 384 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4427
Passed tests: 3991
Skipped tests: 429
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccColabRuntimeTemplateIamBindingGenerated
  • TestAccColabRuntimeTemplateIamMemberGenerated
  • TestAccColabRuntimeTemplateIamPolicyGenerated
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateNoNameExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplate_colabRuntimeTemplateNoNameExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2642 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 16 files changed, 2632 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 749 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 384 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2642 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 16 files changed, 2632 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 749 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 384 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4432
Passed tests: 3992
Skipped tests: 429
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccColabRuntimeTemplateIamBindingGenerated
  • TestAccColabRuntimeTemplateIamMemberGenerated
  • TestAccColabRuntimeTemplateIamPolicyGenerated
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateNoNameExample
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4432
Passed tests: 3993
Skipped tests: 429
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccColabRuntimeTemplateIamBindingGenerated
  • TestAccColabRuntimeTemplateIamMemberGenerated
  • TestAccColabRuntimeTemplateIamPolicyGenerated
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateNoNameExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample [Debug log]
TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample [Debug log]
TestAccColabRuntimeTemplate_colabRuntimeTemplateNoNameExample [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample [Debug log]
TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample [Debug log]
TestAccColabRuntimeTemplate_colabRuntimeTemplateNoNameExample [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1902 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1892 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 374 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 384 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4433
Passed tests: 4000
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had extended review offline, LGTM now with IAM removed and TestAccColabRuntimeTemplate_colabRuntimeTemplate* passing

@c2thorn c2thorn merged commit 9549e70 into GoogleCloudPlatform:main Jan 13, 2025
15 of 16 checks passed
@bcreddy-gcp bcreddy-gcp deleted the colab_template_changes branch January 13, 2025 20:18
bcreddy-gcp added a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 13, 2025
bcreddy-gcp added a commit to bcreddy-gcp/magic-modules that referenced this pull request Jan 15, 2025
anoopkverma-google pushed a commit to anoopkverma-google/magic-modules that referenced this pull request Jan 31, 2025
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants