Add support for extra attributes oauth2 client

[omkark-google]

Add support for extra attributes oauth2 client fields to create workforce pool operation for SAML protocol. This address the gap between newly added support in Gcloud command of iam create workforce pool provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[ScottSuarez]

hashicorp/terraform-provider-google#20862

Omkark, could you register internally so CI can run without manual approval.
go/terraform-contribution-guide#before-you-begin

Also, the release note seems incorrect as no new field is being added. It seems only tests are being added for existing behavior.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 4 files changed, 263 insertions(+), 11 deletions(-))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 11
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

• iamworkforcepool

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIAMWorkforcePoolWorkforcePoolOidcProvider_extraAttributesOauth2Client
• TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample
• TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample
• TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolOidcProvider_extraAttributesOauth2Client [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 265 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 265 insertions(+), 13 deletions(-))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 12
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• iamworkforcepool

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample
• TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample
• TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 266 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 266 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 12
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• iamworkforcepool

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample
• TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample
• TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[ScottSuarez]

Looks like the tests are failing with

        Error: Error creating WorkforcePoolProvider: googleapi: Error 400: Invalid Extra Attributes OAuth2 Client Config. ExtraAttributesOAuth2Client field is only supported for OIDC provider.
        
          with google_iam_workforce_pool_provider.example,
          on terraform_plugin_test.tf line 8, in resource "google_iam_workforce_pool_provider" "example":
           8: resource "google_iam_workforce_pool_provider" "example" {

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 266 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 266 insertions(+), 14 deletions(-))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 12
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• iamworkforcepool

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample
• TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample
• TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 268 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 4 files changed, 268 insertions(+), 16 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 268 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 4 files changed, 268 insertions(+), 16 deletions(-))

[omkark-google]

Hi @ScottSuarez This CL is ready for submission

[ScottSuarez]

could you pull latest changes from main? @omkark-google

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 269 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 4 files changed, 269 insertions(+), 17 deletions(-))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• iamworkforcepool

🟢 All tests passed!

View the build log

[ScottSuarez]

looks like there is a broken tgc test on main

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 269 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 4 files changed, 269 insertions(+), 17 deletions(-))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• iamworkforcepool

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 269 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 4 files changed, 269 insertions(+), 17 deletions(-))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• iamworkforcepool

🟢 All tests passed!

View the build log

[omkark-google]

@ScottSuarez

looks like there is a broken tgc test on main

Is there any work around to get this PR merged ?
We have a launch next week and this PR should go in the next weeks rollout

[ScottSuarez]

yeah I can merge with the check failing for now. This won't be released until the following monday due to the release schedule of the provider. go/terraform-releases

[omkark-google]

Yeah release on 24th Feb should be fine