IAM for Colab runtime template #12742

bcreddy-gcp · 2025-01-13T17:06:17Z

Release Note Template for Downstream PRs (will be copied)

colab: Added IAM to `google_colab_runtime_template`.

github-actions · 2025-01-13T17:06:56Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-01-13T17:17:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2642 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 16 files changed, 2632 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 749 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 384 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-13T18:30:56Z

Tests analytics

Total tests: 4436
Passed tests: 3997
Skipped tests: 429
Affected tests: 10

Click here to see the affected service packages

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-13T18:45:40Z

🟢 Tests passed during RECORDING mode:
TestAccColabRuntimeTemplate_colabRuntimeTemplateBasicExample [Debug log]
TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample [Debug log]
TestAccColabRuntimeTemplate_colabRuntimeTemplateNoNameExample [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-13T21:58:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-13T22:01:18Z

Tests analytics

Total tests: 6
Passed tests: 3
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-13T22:01:31Z

🔴 Tests failed during RECORDING mode:
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-13T22:11:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-13T22:14:01Z

Tests analytics

Total tests: 6
Passed tests: 3
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-13T22:14:16Z

🔴 Tests failed during RECORDING mode:
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-14T00:51:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-14T00:54:30Z

Tests analytics

Total tests: 6
Passed tests: 3
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-14T00:55:31Z

🟢 Tests passed during RECORDING mode:
TestAccColabRuntimeTemplateIamBindingGenerated [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-01-14T01:01:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1088 insertions(+), 682 deletions(-))
google-beta provider: Diff ( 8 files changed, 1088 insertions(+), 672 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 475 insertions(+), 145 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 4 insertions(+), 55 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field data_persistent_disk_spec.disk_size_gb within resource google_colab_runtime_template was either removed or renamed - reference
Field data_persistent_disk_spec.disk_type within resource google_colab_runtime_template was either removed or renamed - reference
Field data_persistent_disk_spec within resource google_colab_runtime_template was either removed or renamed - reference
Field description within resource google_colab_runtime_template was either removed or renamed - reference
Field effective_labels within resource google_colab_runtime_template was either removed or renamed - reference
Field encryption_spec.kms_key_name within resource google_colab_runtime_template was either removed or renamed - reference
Field encryption_spec within resource google_colab_runtime_template was either removed or renamed - reference
Field euc_config.euc_disabled within resource google_colab_runtime_template was either removed or renamed - reference
Field euc_config within resource google_colab_runtime_template was either removed or renamed - reference
Field idle_shutdown_config.idle_timeout within resource google_colab_runtime_template was either removed or renamed - reference
Field idle_shutdown_config within resource google_colab_runtime_template was either removed or renamed - reference
Field labels within resource google_colab_runtime_template was either removed or renamed - reference
Field machine_spec.accelerator_count within resource google_colab_runtime_template was either removed or renamed - reference
Field machine_spec.accelerator_type within resource google_colab_runtime_template was either removed or renamed - reference
Field machine_spec.machine_type within resource google_colab_runtime_template was either removed or renamed - reference
Field machine_spec within resource google_colab_runtime_template was either removed or renamed - reference
Field network_spec.enable_internet_access within resource google_colab_runtime_template was either removed or renamed - reference
Field network_spec.network within resource google_colab_runtime_template was either removed or renamed - reference
Field network_spec.subnetwork within resource google_colab_runtime_template was either removed or renamed - reference
Field network_spec within resource google_colab_runtime_template was either removed or renamed - reference
Field network_tags within resource google_colab_runtime_template was either removed or renamed - reference
Field shielded_vm_config.enable_secure_boot within resource google_colab_runtime_template was either removed or renamed - reference
Field shielded_vm_config within resource google_colab_runtime_template was either removed or renamed - reference
Field terraform_labels within resource google_colab_runtime_template was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template" "primary" {
  runtime_template_config {
    data_disk_config {
      disk_size_gb = # value needed
      disk_type    = # value needed
    }
    description           = # value needed
    enable_euc            = # value needed
    enable_secure_boot    = # value needed
    idle_shutdown_timeout = # value needed
    kms_key               = # value needed
    labels                = # value needed
    machine_config {
      accelerator_count = # value needed
      accelerator_type  = # value needed
      machine_type      = # value needed
    }
    network_config {
      enable_internet_access = # value needed
      network                = # value needed
      subnetwork             = # value needed
    }
    network_tags = # value needed
  }
  runtime_template_id = # value needed
}

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-14T01:03:33Z

Tests analytics

Total tests: 6
Passed tests: 3
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-14T01:03:47Z

🔴 Tests failed during RECORDING mode:
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-14T01:07:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-14T01:07:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 741 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-14T01:09:25Z

Tests analytics

Total tests: 6
Passed tests: 3
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-01-14T01:09:37Z

🔴 Tests failed during RECORDING mode:
TestAccColabRuntimeTemplateIamBindingGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamMemberGenerated [Error message] [Debug log]
TestAccColabRuntimeTemplateIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-14T01:10:30Z

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-14T01:14:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-14T01:14:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-14T01:15:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-14T01:16:53Z

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-14T01:17:26Z

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-14T01:18:04Z

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-14T22:16:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-14T22:19:41Z

Tests analytics

Total tests: 6
Passed tests: 6
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions · 2025-01-16T09:40:36Z

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2025-01-17T00:15:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-17T00:17:34Z

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

SirGitsalot

LGTM, but I think you're going to need to git rebase to clean up the commit history - it includes at least one commit from an author who hasn't signed the CLA (although it looks like they later signed it, at the point of the commit they hadn't)

modular-magician · 2025-01-17T21:58:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 753 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 7 files changed, 753 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 385 insertions(+), 10 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field machine_spec.accelerator_count transitioned from optional+computed to optional google_colab_runtime_template - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-17T22:00:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 753 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 7 files changed, 753 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field machine_spec.accelerator_count transitioned from optional+computed to optional google_colab_runtime_template - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-17T22:00:54Z

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-17T22:03:04Z

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-17T22:03:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 732 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 6 files changed, 732 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field machine_spec.accelerator_count transitioned from optional+computed to optional google_colab_runtime_template - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-17T22:06:18Z

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-17T22:14:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 732 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 732 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-17T22:17:03Z

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-01-17T22:22:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 731 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 375 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime_template_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_colab_runtime_template_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime_template_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2025-01-17T22:25:10Z

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions bot requested a review from SirGitsalot January 13, 2025 17:06

SirGitsalot reviewed Jan 17, 2025

View reviewed changes

github-actions bot requested a review from SirGitsalot January 17, 2025 21:47

Add colab runtime template IAM

fd0091c

bcreddy-gcp force-pushed the colab_template_iam branch from 618fa2b to fd0091c Compare January 17, 2025 22:00

Merge branch 'main' into colab_template_iam

715c87b

undo changes

7938559

SirGitsalot approved these changes Jan 17, 2025

View reviewed changes

SirGitsalot merged commit d0350e9 into GoogleCloudPlatform:main Jan 17, 2025
15 checks passed

This was referenced Jan 17, 2025

IAM for Colab runtime template hashicorp/terraform-provider-google#20963

Merged

IAM for Colab runtime template hashicorp/terraform-provider-google-beta#9091

Merged

IAM for Colab runtime template GoogleCloudPlatform/terraform-google-conversion#3328

Merged

NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Jan 18, 2025

IAM for Colab runtime template (GoogleCloudPlatform#12742)

235f6a3

anoopkverma-google pushed a commit to anoopkverma-google/magic-modules that referenced this pull request Jan 31, 2025

IAM for Colab runtime template (GoogleCloudPlatform#12742)

800b65a

PerlMonker303 pushed a commit to PerlMonker303/magic-modules that referenced this pull request Feb 3, 2025

IAM for Colab runtime template (GoogleCloudPlatform#12742)

280e1e5

niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025

IAM for Colab runtime template (GoogleCloudPlatform#12742)

64babcd

IAM for Colab runtime template #12742

IAM for Colab runtime template #12742

Conversation

bcreddy-gcp commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

modular-magician commented Jan 13, 2025

Diff report

Missing test report

modular-magician commented Jan 13, 2025

Tests analytics

Action taken

modular-magician commented Jan 13, 2025

modular-magician commented Jan 13, 2025

Diff report

Missing test report

modular-magician commented Jan 13, 2025

Tests analytics

Action taken

modular-magician commented Jan 13, 2025

modular-magician commented Jan 13, 2025

Diff report

Missing test report

modular-magician commented Jan 13, 2025

Tests analytics

Action taken

modular-magician commented Jan 13, 2025

modular-magician commented Jan 14, 2025

Diff report

Missing test report

modular-magician commented Jan 14, 2025

Tests analytics

Action taken

modular-magician commented Jan 14, 2025

modular-magician commented Jan 14, 2025

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Jan 14, 2025

Tests analytics

Action taken

modular-magician commented Jan 14, 2025

modular-magician commented Jan 14, 2025

Diff report

Missing test report

modular-magician commented Jan 14, 2025

Diff report

Missing test report

modular-magician commented Jan 14, 2025

Tests analytics

Action taken

modular-magician commented Jan 14, 2025

modular-magician commented Jan 14, 2025

Tests analytics

modular-magician commented Jan 14, 2025

Diff report

Missing test report

modular-magician commented Jan 14, 2025

Diff report

Missing test report

modular-magician commented Jan 14, 2025

Diff report

Missing test report

modular-magician commented Jan 14, 2025

Tests analytics

modular-magician commented Jan 14, 2025

Tests analytics

modular-magician commented Jan 14, 2025

Tests analytics

modular-magician commented Jan 14, 2025

Diff report

Missing test report

modular-magician commented Jan 14, 2025

Tests analytics

github-actions bot commented Jan 16, 2025

modular-magician commented Jan 17, 2025

Diff report

Missing test report

modular-magician commented Jan 17, 2025

Tests analytics

SirGitsalot left a comment