Promote gemini_* resources to ga #12747

JumiDeluxe · 2025-01-14T12:13:09Z

Release Note Template for Downstream PRs (will be copied)

gemini: promoted resources `gemini_code_repository_index`, `gemini_repository_group` to GA.

modular-magician · 2025-01-14T14:13:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2770 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 8 files changed, 49 insertions(+), 61 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

modular-magician · 2025-01-14T15:29:21Z

Tests analytics

Total tests: 4436
Passed tests: 4003
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccGeminiCodeRepositoryIndex_delete
TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroupIamBinding
TestAccGeminiRepositoryGroupIamMember
TestAccGeminiRepositoryGroupIamPolicy
TestAccGeminiRepositoryGroup_noBootstrap
TestAccGeminiRepositoryGroup_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

modular-magician · 2025-01-14T15:43:42Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-14T23:39:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2775 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 10 files changed, 66 insertions(+), 88 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

modular-magician · 2025-01-15T00:55:02Z

Tests analytics

Total tests: 4437
Passed tests: 4004
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccGeminiCodeRepositoryIndex_delete
TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroupIamBinding
TestAccGeminiRepositoryGroupIamMember
TestAccGeminiRepositoryGroupIamPolicy
TestAccGeminiRepositoryGroup_noBootstrap
TestAccGeminiRepositoryGroup_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

modular-magician · 2025-01-15T01:01:44Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-01-15T10:51:42Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-01-16T15:17:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2783 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 10 files changed, 74 insertions(+), 88 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

modular-magician · 2025-01-16T16:31:17Z

Tests analytics

Total tests: 4443
Passed tests: 4013
Skipped tests: 426
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccGeminiCodeRepositoryIndex_delete
TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroupIamBinding
TestAccGeminiRepositoryGroupIamMember
TestAccGeminiRepositoryGroupIamPolicy
TestAccGeminiRepositoryGroup_noBootstrap
TestAccGeminiRepositoryGroup_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

modular-magician · 2025-01-16T16:44:30Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

ScottSuarez

Provider google is assumed when provider = is absent. We can simplify the code by removing these references. For the two publicly facing documentation examples this is blocked but the other instances I have no strong opinion of.

mmv1/templates/terraform/examples/gemini_code_repository_index_basic.tf.tmpl

mmv1/templates/terraform/examples/gemini_repository_group_basic.tf.tmpl

…_basic.tf.tmpl Co-authored-by: Scott Suarez <[email protected]>

…c.tf.tmpl Co-authored-by: Scott Suarez <[email protected]>

modular-magician · 2025-01-16T20:54:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2781 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 10 files changed, 72 insertions(+), 88 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

modular-magician · 2025-01-16T20:54:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2781 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 10 files changed, 72 insertions(+), 88 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

JumiDeluxe · 2025-01-16T20:57:34Z

Provider google is assumed when provider = is absent. We can simplify the code by removing these references. For the two publicly facing documentation examples this is blocked but the other instances I have no strong opinion of.

Thanks for the hint, removed

mmv1/third_party/terraform/services/gemini/iam_gemini_repository_group_test.go.tmpl

…ry_group_test.go.tmpl

mmv1/third_party/terraform/services/gemini/resource_gemini_code_repository_index_test.go.tmpl

…e_repository_index_test.go.tmpl

modular-magician · 2025-01-16T21:08:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2744 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 10 files changed, 34 insertions(+), 88 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

modular-magician · 2025-01-16T21:10:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2743 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 10 files changed, 34 insertions(+), 88 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

modular-magician · 2025-01-16T21:11:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2743 insertions(+), 33 deletions(-))
google-beta provider: Diff ( 10 files changed, 34 insertions(+), 88 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

modular-magician · 2025-01-16T22:08:35Z

Tests analytics

Total tests: 4443
Passed tests: 4013
Skipped tests: 426
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccGeminiCodeRepositoryIndex_delete
TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroupIamBinding
TestAccGeminiRepositoryGroupIamMember
TestAccGeminiRepositoryGroupIamPolicy
TestAccGeminiRepositoryGroup_noBootstrap
TestAccGeminiRepositoryGroup_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

modular-magician · 2025-01-16T22:10:18Z

Tests analytics

Total tests: 4443
Passed tests: 4013
Skipped tests: 426
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccGeminiCodeRepositoryIndex_delete
TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroupIamBinding
TestAccGeminiRepositoryGroupIamMember
TestAccGeminiRepositoryGroupIamPolicy
TestAccGeminiRepositoryGroup_noBootstrap
TestAccGeminiRepositoryGroup_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

modular-magician · 2025-01-16T22:22:42Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-16T22:23:03Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-16T22:23:56Z

Tests analytics

Total tests: 4443
Passed tests: 4013
Skipped tests: 426
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccGeminiCodeRepositoryIndex_delete
TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroupIamBinding
TestAccGeminiRepositoryGroupIamMember
TestAccGeminiRepositoryGroupIamPolicy
TestAccGeminiRepositoryGroup_noBootstrap
TestAccGeminiRepositoryGroup_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

modular-magician · 2025-01-16T22:24:18Z

Tests analytics

Total tests: 4443
Passed tests: 4012
Skipped tests: 426
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccGeminiCodeRepositoryIndex_delete
TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroupIamBinding
TestAccGeminiRepositoryGroupIamMember
TestAccGeminiRepositoryGroupIamPolicy
TestAccGeminiRepositoryGroup_noBootstrap
TestAccGeminiRepositoryGroup_update

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountIdToken_withDelegates

TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

modular-magician · 2025-01-16T22:27:37Z

Tests analytics

Total tests: 4443
Passed tests: 4013
Skipped tests: 426
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccGeminiCodeRepositoryIndex_delete
TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroupIamBinding
TestAccGeminiRepositoryGroupIamMember
TestAccGeminiRepositoryGroupIamPolicy
TestAccGeminiRepositoryGroup_noBootstrap
TestAccGeminiRepositoryGroup_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

modular-magician · 2025-01-16T22:37:22Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-16T22:37:44Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccEphemeralServiceAccountIdToken_withDelegates [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-16T22:40:57Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccApigeeEnvironment_apigeeEnvironmentUpdateTest [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Co-authored-by: Scott Suarez <[email protected]>

Promote gemini_* resources to ga

c7c077a

JumiDeluxe force-pushed the gemini-ga-promote branch from c33ca34 to c7c077a Compare January 14, 2025 14:01

modular-magician added the service/gemini label Jan 14, 2025

Update gemini_* examples and descriptions

d5983fc

JumiDeluxe marked this pull request as ready for review January 15, 2025 10:51

github-actions bot requested a review from ScottSuarez January 15, 2025 10:51

frsv approved these changes Jan 15, 2025

View reviewed changes

JumiDeluxe added 3 commits January 15, 2025 13:02

Remove not supported identifiers from RepositoryGroup IAM members

0de5d1b

Add API references to gemini_* resources

e15dc0c

Remove gemini_* handwritten docs

c5cc4f7

ScottSuarez requested changes Jan 16, 2025

View reviewed changes

mmv1/templates/terraform/examples/gemini_code_repository_index_basic.tf.tmpl Outdated Show resolved Hide resolved

mmv1/templates/terraform/examples/gemini_repository_group_basic.tf.tmpl Outdated Show resolved Hide resolved

JumiDeluxe and others added 2 commits January 16, 2025 21:43

Update mmv1/templates/terraform/examples/gemini_code_repository_index…

ba51448

…_basic.tf.tmpl Co-authored-by: Scott Suarez <[email protected]>

Update mmv1/templates/terraform/examples/gemini_repository_group_basi…

dc192fa

…c.tf.tmpl Co-authored-by: Scott Suarez <[email protected]>

github-actions bot requested a review from ScottSuarez January 16, 2025 20:43

Remove redundant provider fields in gemini_* tests

91098b1

ScottSuarez reviewed Jan 16, 2025

View reviewed changes

mmv1/third_party/terraform/services/gemini/iam_gemini_repository_group_test.go.tmpl Outdated Show resolved Hide resolved

Update mmv1/third_party/terraform/services/gemini/iam_gemini_reposito…

f684379

…ry_group_test.go.tmpl

github-actions bot requested a review from ScottSuarez January 16, 2025 20:59

ScottSuarez reviewed Jan 16, 2025

View reviewed changes

mmv1/third_party/terraform/services/gemini/resource_gemini_code_repository_index_test.go.tmpl Outdated Show resolved Hide resolved

Update mmv1/third_party/terraform/services/gemini/resource_gemini_cod…

e17e5c4

…e_repository_index_test.go.tmpl

github-actions bot requested a review from ScottSuarez January 16, 2025 21:00

ScottSuarez approved these changes Jan 16, 2025

View reviewed changes

ScottSuarez merged commit b5bdbf8 into GoogleCloudPlatform:main Jan 16, 2025
14 of 15 checks passed

This was referenced Jan 16, 2025

Promote gemini_* resources to ga hashicorp/terraform-provider-google-beta#9077

Merged

Promote gemini_* resources to ga hashicorp/terraform-provider-google#20941

Merged

Promote gemini_* resources to ga GoogleCloudPlatform/terraform-google-conversion#3317

Merged

NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Jan 18, 2025

Promote gemini_* resources to ga (GoogleCloudPlatform#12747)

8870187

Co-authored-by: Scott Suarez <[email protected]>

anoopkverma-google pushed a commit to anoopkverma-google/magic-modules that referenced this pull request Jan 31, 2025

Promote gemini_* resources to ga (GoogleCloudPlatform#12747)

9192723

Co-authored-by: Scott Suarez <[email protected]>

niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025

Promote gemini_* resources to ga (GoogleCloudPlatform#12747)

07b4879

Co-authored-by: Scott Suarez <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote gemini_* resources to ga #12747

Promote gemini_* resources to ga #12747

JumiDeluxe commented Jan 14, 2025 •

edited

Loading

modular-magician commented Jan 14, 2025

modular-magician commented Jan 14, 2025

modular-magician commented Jan 14, 2025

modular-magician commented Jan 14, 2025

modular-magician commented Jan 15, 2025

modular-magician commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

ScottSuarez left a comment

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

JumiDeluxe commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

Promote gemini_* resources to ga #12747

Promote gemini_* resources to ga #12747

Conversation

JumiDeluxe commented Jan 14, 2025 • edited Loading

modular-magician commented Jan 14, 2025

Diff report

modular-magician commented Jan 14, 2025

Tests analytics

Action taken

modular-magician commented Jan 14, 2025

modular-magician commented Jan 14, 2025

Diff report

modular-magician commented Jan 15, 2025

Tests analytics

Action taken

modular-magician commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

modular-magician commented Jan 16, 2025

Diff report

modular-magician commented Jan 16, 2025

Tests analytics

Action taken

modular-magician commented Jan 16, 2025

ScottSuarez left a comment

Choose a reason for hiding this comment

modular-magician commented Jan 16, 2025

Diff report

modular-magician commented Jan 16, 2025

Diff report

JumiDeluxe commented Jan 16, 2025

modular-magician commented Jan 16, 2025

Diff report

modular-magician commented Jan 16, 2025

Diff report

modular-magician commented Jan 16, 2025

Diff report

modular-magician commented Jan 16, 2025

Tests analytics

Action taken

modular-magician commented Jan 16, 2025

Tests analytics

Action taken

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

Tests analytics

Action taken

modular-magician commented Jan 16, 2025

Tests analytics

Action taken

modular-magician commented Jan 16, 2025

Tests analytics

Action taken

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

modular-magician commented Jan 16, 2025

JumiDeluxe commented Jan 14, 2025 •

edited

Loading