Adding Labels to Interconnect Attachments

[NA2047]

Adding Labels to Interconnect Attachments field

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: adding Labels field to resource_compute_interconnect_attachment

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 154 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 154 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

[modular-magician]

Tests analytics

Total tests: 1080
Passed tests: 1004
Skipped tests: 73
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 155 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 155 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 155 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 155 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 194 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 194 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1080
Passed tests: 1005
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1080
Passed tests: 1005
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1080
Passed tests: 1005
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 253 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 253 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1080
Passed tests: 1005
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 253 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 253 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1080
Passed tests: 1005
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 254 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 254 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1080
Passed tests: 1004
Skipped tests: 73
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NA2047]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@BBBmau gentle bump on this :)

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[BBBmau]

looks good! Apologies for the late review.