Add AwsMsk & ConfluentCloud to 'google_pubsub_topic'

[andreajialee]

Add AwsMsk ingestion fields & ConfluentCloud ingestion fields to google_pubsub_topic

Release Note Template for Downstream PRs (will be copied)

pubsub: added `ingestion_data_source_settings.aws_msk` and `ingestion_data_source_settings.confluent_cloud` fields to `google_pubsub_topic` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[andreajialee]

I already merged the past commits: #12744

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 298 insertions(+))
google-beta provider: Diff ( 4 files changed, 298 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

[modular-magician]

Tests analytics

Total tests: 60
Passed tests: 57
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• pubsub

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubTopic_awsMskIngestionUpdate
• TestAccPubsubTopic_pubsubTopicIngestionAwsMskExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubTopic_awsMskIngestionUpdate [Debug log]
TestAccPubsubTopic_pubsubTopicIngestionAwsMskExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 618 insertions(+))
google-beta provider: Diff ( 4 files changed, 618 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 137 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 229 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 618 insertions(+))
google-beta provider: Diff ( 4 files changed, 618 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 137 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 229 insertions(+))

[modular-magician]

Tests analytics

Total tests: 62
Passed tests: 59
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• pubsub

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubTopic_confluentCloudIngestionUpdate
• TestAccPubsubTopic_pubsubTopicIngestionConfluentCloudExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubTopic_confluentCloudIngestionUpdate [Debug log]
TestAccPubsubTopic_pubsubTopicIngestionConfluentCloudExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 62
Passed tests: 59
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• pubsub

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccPubsubTopic_confluentCloudIngestionUpdate
• TestAccPubsubTopic_pubsubTopicIngestionConfluentCloudExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccPubsubTopic_confluentCloudIngestionUpdate [Debug log]
TestAccPubsubTopic_pubsubTopicIngestionConfluentCloudExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[NickElliot]

LGTM!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 618 insertions(+))
google-beta provider: Diff ( 4 files changed, 618 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 137 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 229 insertions(+))

[modular-magician]

Tests analytics

Total tests: 62
Passed tests: 61
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• pubsub

🟢 All tests passed!

View the build log

[andreajialee]

Hi! It says these changes are approved but has one pending review and I can see the PR is not merged yet. I have a deadline of Feb 1 and it takes Terraform one week to propagate if submitted by Tuesday. Is there any way to merge this?

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.