Skip to content

Add IAM policy to SecurityGateway.yaml #12782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

Berro321
Copy link
Contributor

@Berro321 Berro321 commented Jan 16, 2025

`google_beyondcorp_security_gateway_iam_binding`
`google_beyondcorp_security_gateway_iam_member`
`google_beyondcorp_security_gateway_iam_policy`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1161 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1161 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 379 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 20
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages
  • beyondcorp
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withAndWithoutCondition

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamPolicyGenerated
  • TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayIamBindingGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated [Error message] [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@Berro321 Berro321 marked this pull request as draft January 17, 2025 01:14
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1161 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1161 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 379 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 20
Skipped tests: 2
Affected tests: 6

Click here to see the affected service packages
  • beyondcorp
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withAndWithoutCondition

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamPolicyGenerated
  • TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@Berro321 Berro321 closed this Jan 21, 2025
@Berro321 Berro321 reopened this Jan 21, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1161 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1161 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 379 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 25
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • beyondcorp
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withAndWithoutCondition

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@Berro321 Berro321 marked this pull request as ready for review January 22, 2025 10:34
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1151 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1151 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 379 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • beyondcorp
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withAndWithoutCondition
    🟢 All tests passed!

View the build log

@shuyama1
Copy link
Member

shuyama1 commented Jan 23, 2025

Triggered skipped tests on TC and I'll update test status after.

Update: all tests pass!

@shuyama1 shuyama1 self-requested a review January 24, 2025 17:51
anoopkverma-google pushed a commit to anoopkverma-google/magic-modules that referenced this pull request Jan 31, 2025
PerlMonker303 pushed a commit to PerlMonker303/magic-modules that referenced this pull request Feb 3, 2025
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants