Skip to content

Modify Quota Adjuster Settings documentation #12818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

gurankitt
Copy link
Member

@gurankitt gurankitt commented Jan 21, 2025

Remove documentation for folder/org support
FIXES hashicorp/terraform-provider-google/issues/20387

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudquotas: removed validation for `parent` in `google_cloud_quotas_quota_adjuster_settings`

@github-actions github-actions bot requested a review from c2thorn January 21, 2025 13:10
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 2 files changed, 5 insertions(+), 39 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field effective_container within resource google_cloud_quotas_quota_adjuster_settings was either removed or renamed - reference
  • Field effective_enablement within resource google_cloud_quotas_quota_adjuster_settings was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudquotas

🟢 All tests passed!

View the build log

@c2thorn
Copy link
Member

c2thorn commented Jan 23, 2025

waiting to hear about breaking change

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 18 insertions(+), 19 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 18 insertions(+), 19 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudquotas

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 4
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudquotas

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new resource Quota Adjuster Settings Manager in Cloud Quotas
3 participants