Skip to content

Increase timeout on google_dataproc_metastore_service to 75m (from 60m) #12824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

rileykarson
Copy link
Member

Related to hashicorp/terraform-provider-google#20978

The underlying operation appears to time out after an hour, but takes a few minutes to report. Since we time out after an hour, we'll never actually hit the failed operation and will time out ourselves in these cases. Add a 15m buffer for time from resource execution start in Terraform + service reporting failure through the LRO + LRO poll from Terraform and we should now pass through the service's underlying failure reason.

The change is still not very useful for debugging, but is still an improvement because it's something rather than a generic Terraform message (and will improve if the API ever sends more details): Error: Error waiting to create Service: Error waiting for Creating Service: timeout while waiting for state to become 'done: true' (last state: 'done: false', timeout: 1h0m0s) -> ~Error: Error waiting to create Service: Error waiting for Creating Service: Error code 4. Operation deadline exceeded.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

metastore: increased timeout on google_dataproc_metastore_service operations to 75m from 60m. This will expose server-returned reasons for operation failure instead of masking them with a Terraform timeout.

@rileykarson rileykarson requested a review from shuyama1 January 21, 2025 20:18
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 25
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants