Colab schedules

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_colab_schedule`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 13
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• colab

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccColabSchedule_colabScheduleBasicExample
• TestAccColabSchedule_colabScheduleFullExample
• TestAccColabSchedule_colabSchedulePausedExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccColabSchedule_colabScheduleBasicExample [Debug log]
TestAccColabSchedule_colabScheduleFullExample [Debug log]
TestAccColabSchedule_colabSchedulePausedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2748 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2748 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 362 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_schedule (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_schedule" "primary" {
  create_notebook_execution_job_request {
    notebook_execution_job {
      execution_user = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• colab

🟢 All tests passed!

View the build log

[melinath]

a couple small tweaks to the update tests to make the resources sweepable, otherwise LGTM

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 7 files changed, 2748 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 362 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_schedule (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_schedule" "primary" {
  create_notebook_execution_job_request {
    notebook_execution_job {
      execution_user = # value needed
    }
  }
}

Errors

google provider:

• Failed to build branch auto-pr-12826-old

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• colab

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccColabSchedule_update
• TestAccColabSchedule_update_state

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccColabSchedule_update [Debug log]
TestAccColabSchedule_update_state [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[melinath]

I'm rerunning the tests due to the error mentioned in the diff comment... but I can't reproduce the problem locally so I suspect it might be a temporary glitch.

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 2748 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 2748 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 362 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_schedule (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_schedule" "primary" {
  create_notebook_execution_job_request {
    notebook_execution_job {
      execution_user = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• colab

🟢 All tests passed!

View the build log

[melinath]

note: merging without tests for execution_user because I ended up using that field to run tests locally, so I have confidence it maps properly. However, it would be good to add tests using it as a follow-up.