Skip to content

Make (R)IGM.PerInstanceConfigs lock on Instance name, not IGM #12829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

askubis
Copy link
Member

@askubis askubis commented Jan 22, 2025

Allow parallelization of per instance config related operations by not locking on the IGM
Fixes b/270736647

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Allow parallelization of google_compute_(region_)per_instance_config by not locking on the parent resource, but including instance name.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1096
Passed tests: 1021
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@askubis askubis changed the title make PerInstanceConfigs lock on Instance, not IGM Make (R)IGM.PerInstanceConfigs lock on Instance name, not IGM Jan 22, 2025
@askubis askubis marked this pull request as ready for review January 22, 2025 20:08
@github-actions github-actions bot requested a review from BBBmau January 22, 2025 20:09
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving since this follows the mutex format in docs: https://googlecloudplatform.github.io/magic-modules/reference/resource/#mutex

@BBBmau BBBmau merged commit b8191da into GoogleCloudPlatform:main Jan 22, 2025
14 of 17 checks passed
anoopkverma-google pushed a commit to anoopkverma-google/magic-modules that referenced this pull request Jan 31, 2025
PerlMonker303 pushed a commit to PerlMonker303/magic-modules that referenced this pull request Feb 3, 2025
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants