Skip to content

Add Security Gateway Application resource #12837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Berro321
Copy link
Contributor

`google_beyondcorp_application`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2270 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 11 files changed, 2270 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 482 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_application" "primary" {
  endpoint_matchers {
    ports = # value needed
  }
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2270 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 11 files changed, 2270 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 482 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_application" "primary" {
  endpoint_matchers {
    ports = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 20
Skipped tests: 2
Affected tests: 8

Click here to see the affected service packages
  • beyondcorp
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBeyondcorpApplicationIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpApplicationIamBindingGenerated
  • TestAccBeyondcorpApplicationIamBindingGenerated_withCondition
  • TestAccBeyondcorpApplicationIamMemberGenerated
  • TestAccBeyondcorpApplicationIamMemberGenerated_withCondition
  • TestAccBeyondcorpApplicationIamPolicyGenerated
  • TestAccBeyondcorpApplicationIamPolicyGenerated_withCondition
  • TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample
  • TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 30
Passed tests: 20
Skipped tests: 2
Affected tests: 8

Click here to see the affected service packages
  • beyondcorp
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBeyondcorpApplicationIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpApplicationIamBindingGenerated
  • TestAccBeyondcorpApplicationIamBindingGenerated_withCondition
  • TestAccBeyondcorpApplicationIamMemberGenerated
  • TestAccBeyondcorpApplicationIamMemberGenerated_withCondition
  • TestAccBeyondcorpApplicationIamPolicyGenerated
  • TestAccBeyondcorpApplicationIamPolicyGenerated_withCondition
  • TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample
  • TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@Berro321 Berro321 marked this pull request as ready for review January 23, 2025 10:14
@github-actions github-actions bot requested a review from c2thorn January 23, 2025 10:15
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@Berro321
Copy link
Contributor Author

Sending a friendly ping for review @c2thorn

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good to me, solid PR. Thanks for the update test!

@c2thorn c2thorn merged commit ff7f731 into GoogleCloudPlatform:main Jan 29, 2025
17 checks passed
trodge added a commit that referenced this pull request Jan 29, 2025
anoopkverma-google pushed a commit to anoopkverma-google/magic-modules that referenced this pull request Jan 31, 2025
PerlMonker303 pushed a commit to PerlMonker303/magic-modules that referenced this pull request Feb 3, 2025
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants