Skip to content

alloydb: marked google_alloydb_user.password as sensitive #12838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

wyardley
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#20996

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

alloydb: marked `google_alloydb_user.password` as sensitive

@github-actions github-actions bot requested a review from melinath January 23, 2025 05:39
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/alloydb and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 23, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+))
google-beta provider: Diff ( 2 files changed, 6 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 75
Passed tests: 73
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • alloydb

🟢 All tests passed!

View the build log

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_alloydb_user password argument is not marked sensitive so is displayed in plan output
3 participants