feat: added disabled_user_signup and disabled_user_deletion to google_identity_platform_tenant

[ramonvermeulen]

Solves hashicorp/terraform-provider-google#20918

Adds support for these two configuration options in the API Endpint:

  client {
    permissions {
      disabled_user_signup   = true
      disabled_user_deletion = true
    }
  }

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

identityplatform: added `disabled_user_signup` and `disabled_user_deletion` to `google_identity_platform_tenant`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 185 insertions(+))
google-beta provider: Diff ( 4 files changed, 185 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 59 insertions(+))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 14
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages

• identityplatform

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIdentityPlatformTenant_identityPlatformTenantUpdate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccIdentityPlatformTenant_identityPlatformTenantUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 185 insertions(+))
google-beta provider: Diff ( 4 files changed, 185 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 59 insertions(+))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 15
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• identityplatform

🟢 All tests passed!

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

Apologies, have been low on cycles and taking too long to get back to reviews. Picking an alternate reviewer.

@modular-magician reassign-reviewer

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

OK let's see if it works this time:

@modular-magician reassign-reviewer

[roaks3]

Some minor feedback, but overall LGTM

[ramonvermeulen]

@roaks3 Thanks for the feedback, just updated the PR!

[roaks3]

Could you revert to using single quotes for the string values in the yaml, so that we don't have these no-op changes in the diff?

Otherwise, LGTM, and should be ready to run tests

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 175 insertions(+))
google-beta provider: Diff ( 4 files changed, 175 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 59 insertions(+))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 15
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• identityplatform

🟢 All tests passed!

View the build log