Skip to content

fix: (storage) update doc to link google_storage_bucket_object_content in google_storage_bucket_object #12854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

gurusai-voleti
Copy link
Contributor

@gurusai-voleti gurusai-voleti commented Jan 24, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

@kautikdk
Copy link
Member

What is the need of this change?

@gurusai-voleti
Copy link
Contributor Author

What is the need of this change?

to navigate users better to know about the data source resource of bucket objects, a bug raised for by user seeking examples of datasource resource for bucket objects but it exists without navigation in documentation

@gurusai-voleti gurusai-voleti marked this pull request as ready for review January 31, 2025 04:32
@github-actions github-actions bot requested a review from NickElliot January 31, 2025 04:33
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@@ -13,6 +13,10 @@ Creates a new object inside an existing bucket in Google cloud storage service (
and
[API](https://cloud.google.com/storage/docs/json_api/v1/objects).

A datasource can be used to retrive data of the object

* `google_storage_bucket_object_content`: Retrieves the data of the object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add link to the data source? It will help users to directly navigate to data source reference documentation.
nit: "Retrieves the data of the object."

Copy link
Contributor Author

@gurusai-voleti gurusai-voleti Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean the terraform final documentation URL link? we don't know it and there is no specific documentation for the google_storage_bucket_object_content in Google docs

updated description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@kautikdk kautikdk Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds Good!
Actually I was talking about this documentation but it's fine. We can follow same pattern here that was used in other resources.
Also please make sure to keep none as release-note type since there is no user impact with this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes release-note is none type

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworded, let me know if these sound better to you

@github-actions github-actions bot requested a review from NickElliot February 4, 2025 04:26
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 1 file changed, 4 insertions(+))

@gurusai-voleti
Copy link
Contributor Author

reworded, let me know if these sound better to you

Updated with the suggestion

@NickElliot NickElliot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into GoogleCloudPlatform:main with commit c147b6b Feb 5, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants