Mark content in storage object content data source as computed

[wafrelka]

Fixes hashicorp/terraform-provider-google#15717 in a backward-compatible manner.

The bug was once fixed in #10778, but it is reverted due to backward incompatibility.
This pull request retries to fix the bug without affecting to existing configuration.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: fixed an issue where plans with a dependency on the `content` field in the `google_storage_bucket_object_content` data source could erroneously fail

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[slevenick]

Odd, so the issue here is that the field should be Computed and not Optional, but due to it being marked as Optional in the past we have to keep it that way?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 60 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 60 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 117
Passed tests: 106
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages

• storage

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceStorageBucketObjectContent_Issue15717
• TestAccDataSourceStorageBucketObjectContent_Issue15717BackwardCompatibility

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceStorageBucketObjectContent_Issue15717 [Debug log]
TestAccDataSourceStorageBucketObjectContent_Issue15717BackwardCompatibility [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[wafrelka]

Odd, so the issue here is that the field should be Computed and not Optional, but due to it being marked as Optional in the past we have to keep it that way?

Yes.

According to the document, the field is supposed to be Computed and non-Optional.